1006986 - flame debug build failed on MOZ_ASSERT_IF() in dom/bluetooth/bluez/BluetoothDBusService.cpp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I build flame debug on Mac OS X 10.9. The error message is as follows:

BluetoothDBusService.o
../../../gecko/dom/bluetooth/bluez/BluetoothDBusService.cpp: In member function 'virtual void mozilla::dom::bluetooth::BluetoothDBusService::SendMetaData(const nsAString_internal&, const nsAString_internal&, const nsAString_internal&, int64_t, int64_t, int64_t, mozilla::dom::bluetooth::BluetoothReplyRunnable*)':
../../../gecko/dom/bluetooth/bluez/BluetoothDBusService.cpp:3892:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
In file included from ../../../gecko/ipc/chromium/src/base/basictypes.h:14:0,
                 from ../../../gecko/dom/bluetooth/bluez/BluetoothDBusService.cpp:19:
../../dist/include/mozilla/Assertions.h: In instantiation of 'void mozilla::detail::ValidateAssertConditionType() [with T = const char (&)[26]]':
../../../gecko/dom/bluetooth/bluez/BluetoothDBusService.cpp:1114:129:   required from here
../../dist/include/mozilla/Assertions.h:322:3: error: static assertion failed: Expected boolean assertion condition, got an array or a string!

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Fix build fail for flame debug.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8418540 [details] [diff] [review]
Fix build fail for flame debug.

Review of attachment 8418540 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Ting-Yu!

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8418540 [details] [diff] [review]
Fix build fail for flame debug.

Review of attachment 8418540 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluez/BluetoothDBusService.cpp
@@ +1110,5 @@
>          parameters.AppendElement(properties[i]);
>          break;
>        }
>      }
> +    MOZ_ASSERT(i != properties.Length(), "failed to get device name");

You are inverting the condition.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #3)
> Comment on attachment 8418540 [details] [diff] [review]
> Fix build fail for flame debug.
> 
> Review of attachment 8418540 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bluetooth/bluez/BluetoothDBusService.cpp
> @@ +1110,5 @@
> >          parameters.AppendElement(properties[i]);
> >          break;
> >        }
> >      }
> > +    MOZ_ASSERT(i != properties.Length(), "failed to get device name");
> 
> You are inverting the condition.

Oh, I just saw the difference. Never mind. :)

Comment 5

[Eric Chou [:ericchou] [:echou]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #4)
> (In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #3)
> > Comment on attachment 8418540 [details] [diff] [review]
> > Fix build fail for flame debug.
> > 
> > Review of attachment 8418540 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: dom/bluetooth/bluez/BluetoothDBusService.cpp
> > @@ +1110,5 @@
> > >          parameters.AppendElement(properties[i]);
> > >          break;
> > >        }
> > >      }
> > > +    MOZ_ASSERT(i != properties.Length(), "failed to get device name");
> > 
> > You are inverting the condition.
> 
> Oh, I just saw the difference. Never mind. :)

I was really surprised at how long the original MOZ_ASSERT_IF exists in our codebase. :-|

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

And ASSERT_IF is such a bad name, because 'assert' means to me 'expect something to be true', not 'warn and abort'. Good to see this gone. :D

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=cabcdcb10cba

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a0840fbb59fd

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a0840fbb59fd