Closed Bug 1006995 Opened 6 years ago Closed 6 years ago

Fix the failure of test_sms_to_dialer.py

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: askeing, Assigned: askeing)

References

Details

Attachments

(1 file, 1 obsolete file)

Build under tests:
    Gaia      98ca8c55dbe2f21a8661d0eaa87f34d316c3bc98
    Gecko     https://hg.mozilla.org/mozilla-central/rev/4e4e0f502969
    BuildID   20140506160204
    Version   32.0a1
    ro.build.version.incremental=324
    ro.build.date=Thu Dec 19 14:04:55 CST 2013

Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest.non-smoketest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.7-py2.7.egg/marionette/marionette_test.py", line 163, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest.non-smoketest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_to_dialer.py", line 34, in test_dialer_from_message
keypad = message_thread.tap_call()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest.non-smoketest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/messages/regions/message_thread.py", line 48, in tap_call
keypad.wait_for_phone_number_ready()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest.non-smoketest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/phone/regions/keypad.py", line 93, in wait_for_phone_number_ready
self.wait_for_condition(lambda m:
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest.non-smoketest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 54, in wait_for_condition
Wait(self.marionette, timeout).until(method, message=message)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest.non-smoketest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.7-py2.7.egg/marionette/wait.py", line 122, in until
rv = condition(self.marionette)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest.non-smoketest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/phone/regions/keypad.py", line 94, in <lambda>
'true' not in m.find_element(*self._add_new_contact_button_locator).get_attribute('aria-disabled'))
TypeError: argument of type 'NoneType' is not iterable
Assignee: nobody → fyen
Attached file PR 19017 (obsolete) —
Attachment #8418580 - Flags: review?(zcampbell)
Attachment #8418580 - Flags: review?(florin.strugariu)
See Also: → 1006999
Comment on attachment 8418580 [details] [review]
PR 19017

This lgtm and works fine, but I thinks Bug 1006999 should be reported in the Dialer component.
Attachment #8418580 - Flags: review+
Comment on attachment 8418580 [details] [review]
PR 19017

r-, in this test case is very important that this is visible to the user.

We need to find the problem as to why we can't see the text.
Attachment #8418580 - Flags: review?(zcampbell) → review-
We can't resolve this until investigation in bug 1006999 is complete. We may end up xfailing this.
Depends on: 1006999
No longer depends on: 1006999
Comment on attachment 8418580 [details] [review]
PR 19017

some of these changes are not required
Attachment #8418580 - Flags: review?(florin.strugariu) → review-
Attachment #8418580 - Attachment is obsolete: true
Attachment #8418686 - Flags: review?(zcampbell)
Attachment #8418686 - Flags: review?(andrei.hutusoru)
Comment on attachment 8418686 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19031/files

r+
Attachment #8418686 - Flags: review?(zcampbell) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.