1007033 - Inline activity is dismissed on Home button press

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Oleg Zasypkin [:azasypkin]]

This is follow-up from 1.3+ blocker bug 999286. Since it has been already fixed in master (via bug 916709), it would be great if we can uplift the fix to v1.4. 

For the STR that make this bug blocking see bug 999286 comment 10.

Comment 1

[Jason Smith [:jsmith]]

Too risky. We should implement a temporary workaround for 1.4 & 1.3 in bug 999286.

Comment 2

[Julien Wajsberg [:julienw]]

Alive himself said it could be done, maybe we can wait for the patch before deciding it's too risky?

Comment 3

[Julien Wajsberg [:julienw]]

We can definitely apply bug 999286 fix in v1.4, but this does not fix all the cases (see especially bug 999286 comment 10), and these other cases are important too (if not more important IMO).

Comment 4

[Jason Smith [:jsmith]]

(In reply to Julien Wajsberg [:julienw] (away May 8th) from comment #2)
> Alive himself said it could be done, maybe we can wait for the patch before
> deciding it's too risky?

We've already had a blocking regression from the patch suggested here, so I think there's already firm evidence that there's definite risk here.

So I think we need to pursue the same solution across 1.3 & 1.4, so moving back to a WONTFIX.

Comment 5

[Julien Wajsberg [:julienw]]

Jason, I believe Alive wanted to fix this without uplifting the whole popup manager patch, which admittedly would be risky.

Alive, can you please comment here?

Note that the partner would like this (see bug 999286 comment 56).

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

I can have a simple patch to do this, but note:
since we have gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=931339
we need to find a timing to dismiss the opened activity window, otherwise if there's a new request with same target the message will be sent to the old one.

I will open another bug for this since master has this issue.

Comment 7

[Julien Wajsberg [:julienw]]

(In reply to Alive Kuo [:alive][NEEDINFO!][5/11-5/15@MV] from comment #6)
> I can have a simple patch to do this, but note:
> since we have gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=931339
> we need to find a timing to dismiss the opened activity window, otherwise if
> there's a new request with same target the message will be sent to the old
> one.

and is it not possible to dismiss the opened activity window if a new activity is sent? I think that's already what we're doing in v1.4?


> 
> I will open another bug for this since master has this issue.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Julien Wajsberg [:julienw] from comment #7)
> (In reply to Alive Kuo [:alive][NEEDINFO!][5/11-5/15@MV] from comment #6)
> > I can have a simple patch to do this, but note:
> > since we have gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=931339
> > we need to find a timing to dismiss the opened activity window, otherwise if
> > there's a new request with same target the message will be sent to the old
> > one.
> 
> and is it not possible to dismiss the opened activity window if a new
> activity is sent? I think that's already what we're doing in v1.4?

No, for v1.4 we do dismiss activity once home button is pressed for now
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/system/js/activity_window_factory.js#L174

I have WIP in https://bugzilla.mozilla.org/show_bug.cgi?id=1008928 to improve
1. Keep activities until home + new request is coming because if we do 'dismiss the opened activity window if a new activity is sent' we cannot have a inline activity chain (inline call inline) and will break lots of apps having it.

But julien, after thing again, I really think sms should not be invoked by inline activities.
Think about this:
1. contact -> inline sms edit
2. go home
3. open sms: you will see sms drafts there and you could enter to edit.

Now you have two editing screen for the same message draft. Isn't it strange?

Comment 9

[Julien Wajsberg [:julienw]]

I understand what you mean.

I think what I'm missing is a big picture about activities: what inline and window activities are supposed to be and when/how they're supposed to be used... It's never been completely clear to me. Is it worth starting a thread on dev-b2g?

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> I understand what you mean.
> 
> I think what I'm missing is a big picture about activities: what inline and
> window activities are supposed to be and when/how they're supposed to be
> used... It's never been completely clear to me. Is it worth starting a
> thread on dev-b2g?

From my point of view:
* Inline == multiple instances
* Window == single instances

So if you have trouble to have multiple instance, for example, email app has trouble to access mail database? in two instances so they tend to use window disposition.

In sms use case if UX like inline more, when sms app itself is opened later, it should notice the opened inline frame to close itself by shared worker or some other in-app communications.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!][5/11-5/15@MV] from comment #10)
> (In reply to Julien Wajsberg [:julienw] from comment #9)
> > I understand what you mean.
> > 
> > I think what I'm missing is a big picture about activities: what inline and
> > window activities are supposed to be and when/how they're supposed to be
> > used... It's never been completely clear to me. Is it worth starting a
> > thread on dev-b2g?
> 
> From my point of view:
> * Inline == multiple instances
> * Window == single instances
> 
> So if you have trouble to have multiple instance, for example, email app has
> trouble to access mail database? in two instances so they tend to use window
> disposition.
> 
> In sms use case if UX like inline more, when sms app itself is opened later,
> it should notice the opened inline frame to close itself by shared worker or
> some other in-app communications.

Furthermore, app A is picking picture from gallery activity and app B is picking picture too.
They should be standalone tasks so they should use inline. Though we don't support two gallery activities at the same time for now.

Comment 12

[BMO Automation]

Firefox OS is not being worked on