1007055 - Remove setting of keyboard ftu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P4)

Description

[Zac C (:zac)]

The keyboard FTU has been removed so we can remove the `set` of this.

If running gaiatest against some old versions that do have the ftu, the setting can be set by adding it into the testvars.json file which will set it at the same time point during cleanup_gaia.

Comment 1

[Zac C (:zac)]

Attachment: github pr

Comment 2

[Florin Strugariu [:Bebe]]

Looks good on master 

Fails on other (tested 1.3) 

I think if this will be released and will run on older versions we will create big issues. 

Can we isolate this on only 2.0? Because if we add stuff in testvars.json we will have the same effect as this code change.

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8419286 [details] [review]
github pr

This seems fine on master, and I ran the marketplace-tests-gaia suite with it on v1.3 and that was fine too, likely because the keyboard ftu does not affect that suite.

So this gets my r+, but we should probably let Dave know about it as he may want to test the suites he has running on v1.3.

Comment 4

[Zac C (:zac)]

Sorry I meant to respond to this, I was going to say it's OK to hold off on this one for a while.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8419286 [details] [review]
github pr

The packages I look after do not use GaiaTestCase.setUp so will be unaffected.

Comment 6

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/9fde4665dd547b3c3d5ad8389bffd0862d5c26cd