1007107 - Function branchTestMagicValue is wrong on X64, ARM and MIPS

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Branislav Rankov [:rankov]]

Function branchTestMagicValue in MacroAssembler has a bug in the case when condition is NotEqual.

Comment 1

[Branislav Rankov [:rankov]]

Attachment: test-magic-value.patch

Carry review from previous patch.

This patch has been moved here from bug 994716 after review.

Comment 2

[Branislav Rankov [:rankov]]

Attachment: test-magic-value-mips-arm-x64.patch

Comment 3

[Branislav Rankov [:rankov]]

Comment on attachment 8425496 [details] [diff] [review]
test-magic-value-mips-arm-x64.patch

I changed this to be the same for ARM, X64 and MIPS. 

If you think that this is better than previous patch, I will make the previous patch obsolete.

Comment 4

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8425496 [details] [diff] [review]
test-magic-value-mips-arm-x64.patch

Review of attachment 8425496 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! :)
Do the same thing for x86.

I have only one doubt on x64, where I guess we might store the Value as a relocatable value.  I guess it might not be that important, but it would be better to check about that on try.

Comment 5

[Branislav Rankov [:rankov]]

Attachment: test-magic-value-mips-arm-x64.patch

Carry review from previous patch.
Updated r=nbp.

Comment 6

[Branislav Rankov [:rankov]]

Attachment: test-magic-value-x86.patch

Comment 7

[Branislav Rankov [:rankov]]

(In reply to Nicolas B. Pierron [:nbp] from comment #4)
> Nice! :)
> Do the same thing for x86.

Thanks. I just made a patch for this too.

> I have only one doubt on x64, where I guess we might store the Value as a
> relocatable value.  I guess it might not be that important, but it would be
> better to check about that on try.

I have put both patches to try:
https://tbpl.mozilla.org/?tree=Try&rev=5b3a33d3f9fe

Comment 8

[Branislav Rankov [:rankov]]

Checkin is needed. Here is try link:
https://tbpl.mozilla.org/?tree=Try&rev=5b3a33d3f9fe

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e45c6143959
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc1bff97f035

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e45c6143959
https://hg.mozilla.org/mozilla-central/rev/cc1bff97f035