1007121 - Building with HAIDA=1 doesn't guarantee that home2 is installed or selected

Status: RESOLVED DUPLICATE of bug 1009111

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Chris Lord [:cwiiis]]

If you build with HAIDA=1 to enable the rocketbar, home2 isn't necessarily installed (for example, if you're building with GAIA_APP_TARGET=production) - this means that you're stuck with a home-screen that is partially obscured by the rocketbar.

I think that Haida should at least guarantee that home2 is installed, if not even selected as the default homescreen when HOMESCREEN isn't explicitly set.

Comment 1

[Dale Harvey (:daleharvey)]

So they are somewhat conflated, the partially obscured homescreen is just a bug in the rocketbar implementation, it needs to be compatible with both homescreens

But I do think HAIDA=1 should enable home2 by default

Comment 2

[Dale Harvey (:daleharvey)]

https://bugzilla.mozilla.org/show_bug.cgi?id=995021 is tracking the rocketbar fix

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/daleharvey/gaia/commit/ceef1309dde61f4693709a338d98d4e1b8ef0228

This makes sure the home2 app gets installed

Kevin how would I set it on by default, |HOMESCREEN=app://home2.gaiamobile.org make reset-gaia| on a plain build throws an error

Comment 4

[Kevin Grandon :kgrandon]

Hmm, I am not sure off the top of my head what that flag does. I know this works for me if I place this in custom-settings.json though:

"homescreen.manifestURL": "app://home2.gaiamobile.org/manifest.webapp"

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8420521 [details]
https://github.com/daleharvey/gaia/commit/ceef1309dde61f4693709a338d98d4e1b8ef0228

Updated the patch to set the home2 as the default homescreen

I believe HOMESCREEN= is broken, http://mxr.mozilla.org/gaia/source/build/preferences.js#26 is the only place that uses it, and cant really understand how that logic is correct, happy to file a new issue and remove it if thats true

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

HOMESCREEN isn't used for setting homescreen app, it's used for system app (we have bug 952373 for it)

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Dale, I'm working on refactoring the magic part[1] in Makefile for generating GAIA_APPDIRS and rewrite it in javascript on bug 997004 which target milestone is 2.0S2 (May, 23)

after that bug landed, it should be pretty easy to add home2 if HAIDA=1. can we wait bug 997004 landed? or this bug is critical that we need to land your commit first?

[1] https://github.com/mozilla-b2g/gaia/blob/de1c755411949b50ae395b42e124af215ed9b702/Makefile#L357-L377

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 8420521 [details]
https://github.com/daleharvey/gaia/commit/ceef1309dde61f4693709a338d98d4e1b8ef0228

Since the build is being rewritten, and vertical homescreen is to be enabled by default shortly, will close as a dupe