Closed Bug 1007147 Opened 6 years ago Closed 6 years ago

Fit visual details to icon's label

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 3 obsolete files)

14px regular
color #fff opacity 100%

dropshadow:
vertical offset 2px
size 8px
opacity 100%
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Visual details were obtained from https://mozilla.app.box.com/s/65hcq8nmnm3xpixpazxf
Attached patch 1007147.patch (obsolete) — Splinter Review
WIP
After landing bug 985459 I will create a pull request for this task
Attached image 3 cols.png (obsolete) —
Attached image 4 cols.png (obsolete) —
Comment on attachment 8418759 [details] [diff] [review]
1007147.patch

Review of attachment 8418759 [details] [diff] [review]:
-----------------------------------------------------------------

::: dev_apps/home2/js/grid/grid_item.js
@@ +80,4 @@
>  
>          nameEl = document.createElement('span');
>          nameEl.className = 'title';
> +        nameEl.style.marginTop = layout.gridIconSize + 'px';

FYI - I may have just changed the CSS enough that this is no longer relevant. It's now absolutely positioned from the bottom in CSS (but is probably not to spec). See: https://github.com/mozilla-b2g/gaia/commit/cdb5685e0f7cff8d0281c94eaba9eaece757398d#diff-fa358dde23c17bff4bd73da53bf5dda1R29
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S1 (9may)
Attached file Github pull request
Thanks for the review
Attachment #8418759 - Attachment is obsolete: true
Attachment #8418760 - Attachment is obsolete: true
Attachment #8418761 - Attachment is obsolete: true
Attachment #8419371 - Flags: review?(kgrandon)
Attachment #8419371 - Flags: review?(kgrandon) → review+
The new homescreen is starting to look really nice. Thanks for the patch!

https://github.com/mozilla-b2g/gaia/commit/7aaa80a73d83ffbdfc9c4af693f1d44ccb52d63d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Hey - I noticed that the homescreen could do this weird x-axis panning thing that didn't feel right. I checked in a quick fix that may impact the truncation in this patch, it's here: https://github.com/mozilla-b2g/gaia/commit/ce189cfd21927a87ab445a0079f7003f50454f9f

Looking at it again I think I may have broken the overflow/bookmark background with it unfortunately. I will take a look when I get a chance.
feature-b2g: --- → 2.0
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.