1007148 - [Dialer][Call Screen] Call status, duration and direction refactoring

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

The current code which deals with showing the call status ("Incoming", "Connecting" and "Call Ended" messages), ongoing and total duration (once the call ends) and direction of the call is probably more complex than needed as a consequence of the distinct iterations it has experienced and some refactoring is needed.

The current HTML code looks like this:
<div class="duration">
  <span class="font-light"></span>
  <div class="direction"></div>
  <div class="total-duration font-light"></div>
</div>

Right now, the span element is used to show the status of the call when it's being established ("Incoming" or "Outgoing"). Once it is established it is used to hold the call duration until it ends. At this point it is used to show the "Call Ended" message.

As already discussed with Doug Sherk in bug 1003846 a more "natural" structure should be used such as (please, take it only as a reference):
<div class="call-info"> <!-- Or any other informative name. -->
  <div class="call-status font-light"></div>
  <div class="duration font-light"></div>
  <div class="direction"></div>
</div>

In which case, the .call-status element would hold the current status of the call, this is the text "Incoming" or "Connecting" when being established, hidden during the call and showing "Call Ended" once it ends.

On the other hand, the .duration element would hold the duration of the call once it is established and, consequently, its total duration once it ends.

Please, take into account that this minor change, at least in principle, has important implications in the styling (oncall.css file) and call management code (handled_call.js and conference_group_handler.js, mainly) as a way to cover all the possible call scenarios, these are: 1) 1 to 1 calla, 2) call waiting, 3) conference calls and 4) call information in the status bar.

Comment 1

[Doug Sherk (:drs) (inactive)]

Looks good! I'm kind of backseat driving here, but I would suggest changing "call-status" to "call-state", and perhaps rename "duration" to "call-duration" and "direction" to "call-direction" while we're at it. Just little things we can do while we're already at it.

Comment 2

[BMO Automation]

Firefox OS is not being worked on