Closed Bug 1007242 Opened 8 years ago Closed 7 years ago

In PostgreSQL's crashstorage module, function get_raw_crash() cannot work

Categories

(Socorro :: Backend, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: adrian, Assigned: lars)

Details

Attachments

(1 file)

In file socorro/external/postgresql/crashstorage.py - function _get_raw_crash_transaction - line 164
https://github.com/mozilla/socorro/blob/master/socorro/external/postgresql/crashstorage.py#L164
>        fetch_sql = 'select raw_crash from %s where uuid = %ss' % \
>                    raw_crash_table_name

This will raise a `TypeError: not enough arguments for format string` every time it runs. I suspect it should read ``%%s`` instead of ``%ss``. However, I wonder why this was not caught before? We have a lot of unit tests in socorro/unittest/external/postgresql/test_crashstorage.py but the get_raw_crash function doesn't appear to be covered.
Assignee: nobody → lars
Target Milestone: --- → 86
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/bf58dbe981b3023fc51d74cc605ef07c15b15135
Merge pull request #2047 from twobraids/pg_too_many_s

Fixes  Bug 1007242 - corrected SQL parameters & added get_raw_crash test
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.