Closed Bug 1007337 Opened 10 years ago Closed 10 years ago

Update OneAndDone to use django-browserid 0.10.1

Categories

(Mozilla QA Graveyard :: One and Done, defect, P4)

Product:
Mozilla QA Graveyard
Component:
One and Done
Version:
Version 2
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Milestone 2

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Details

Attachments

(1 file, 1 obsolete file)

Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/173
46 bytes, text/x-github-pull-request
Details | Review 
      No description provided.
Comment on attachment 8418971 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/173

Looks good! :D
Attachment #8418971 - Flags: review?(mkelly) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Milestone 1
This was actually backed out due to it not working on staging, so this bug is not accurate. Reopening this as it should be done at some point, but I will need some assistance with it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Milestone 1 → Milestone 2
Is this something that is feasible for Q3 v2 milestone2- or should it be moved out?
Flags: needinfo?(bob.silverberg)
I'd say move it out. I tried to implement the latest version of django-browserid and was successful locally but there were problems on dev that I haven't been able to figure out yet.
Flags: needinfo?(bob.silverberg)
Updated target to Future
Target Milestone: Milestone 2 → Future
Version: Version 1 → unspecified
Attachment #8418971 - Attachment description: Pull request → Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/173
Attachment #8418971 - Attachment is obsolete: true
Comment on attachment 8485702 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/173

This landed in https://github.com/mozilla/oneanddone/commit/3c8f9f670f080b8c8cbce1250175554593c0ba82. It has been pushed to dev and stage. To test, just try logging in and out.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Verified on both dev and staging.
Status: RESOLVED → VERIFIED
Priority: -- → P4
Target Milestone: Future → Milestone 2
Version: unspecified → Version 2
Rebecca, I'd like to push this today. Please ping me in irc when it would be a good time to push.
Flags: needinfo?(rbillings)
Flags: needinfo?(rbillings)
Verified on prod
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: