1007431 - Add menu item that links to SUMO help

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Chenxia Liu [:liuche]]

Found bug 725006 that discussed this in the past. I assume that we want to put it in the menu?

I would be inclined to stick "Help" in the next to last position, right above Settings, because this keeps Settings easy to tap (and it's probably going to be more used than the Help menu).

The SUMO FAQ would also be more useful to link to than the SUMO main page - if they don't find what they're looking for, they can search there, instead of getting dropped into the main SUMO page and making them type/search from there.

We'll need to get the Mobile SUMO FAQ updated, though, because the current page claims it's not maintained.

Comment 1

[Chenxia Liu [:liuche]]

Roland, is updating the Mobile SUMO FAQ something that you can look into?

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Chenxia Liu [:liuche] from comment #1)
> Roland, is updating the Mobile SUMO FAQ something that you can look into?

hi Chenxia: most definitely, jsavage (who I have CC'd), our SUMO content editor,  will write it (or find the best way to modify an existing article which could even be the existing mobile faq) and i will review it!

Comment 3

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:joni i have added this item to your spreadsheet at:
https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0Amy0OSD97CR6dGF4ZkhVaFFnaEI1cWhpR0dyM1hlaUE&usp=drive_web#gid=3 (row 12)

:liuche this is for FF32 right?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Roland Tanglao :rolandtanglao from comment #3)

> :liuche this is for FF32 right?

Yes

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: help-menu v0.1

The patch adds the menu item for all layouts. I put made it the last item in the menu, except when the Guest Browsing menu is active. This matches several other apps that I found using Help menus too.

The code opens the main SUMO page for Firefox for Android. The same one used by the bookmark and the about: page link to Support. This seems better suited for "Help" than the FAQ page.

Review to Newman mainly for the locale stuff I cribbed from some Sync code. Otherwise, it's a simple patch.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8427227 [details] [diff] [review]
help-menu v0.1

Review of attachment 8427227 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/locales/en-US/android_strings.dtd
@@ +228,5 @@
>  <!ENTITY pref_update_autodownload_wifi "Only over Wi-Fi">
>  <!ENTITY pref_update_autodownload_never "Never">
>  <!ENTITY pref_update_autodownload_always "Always">
>  
> +<!ENTITY help "Help">

Might want to call this something more clearly localizable, like menu_help. Not every language has noun == imperative verb.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Switched to help_menu and added a localization hint
https://hg.mozilla.org/integration/fx-team/rev/480860e8a7f2

Comment 8

[:Margaret Leibovic]

Comment on attachment 8427227 [details] [diff] [review]
help-menu v0.1

Review of attachment 8427227 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/BrowserApp.java
@@ +1247,2 @@
>                              menu.findItem(R.id.settings).setEnabled(true);
> +                            menu.findItem(R.id.help).setEnabled(true);

Drive-by: We could techincally still open a tab and get a page ready to load if gecko isn't running yet. But maybe it would annoy users that their help page doesn't immediately load?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #8)
> Comment on attachment 8427227 [details] [diff] [review]
> help-menu v0.1
> 
> Review of attachment 8427227 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/BrowserApp.java
> @@ +1247,2 @@
> >                              menu.findItem(R.id.settings).setEnabled(true);
> > +                            menu.findItem(R.id.help).setEnabled(true);
> 
> Drive-by: We could techincally still open a tab and get a page ready to load
> if gecko isn't running yet. But maybe it would annoy users that their help
> page doesn't immediately load?

I am willing to wait and see how things go. We could do the same for Settings too. We do know that some people dislike the disabled Settings menu.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/480860e8a7f2

Comment 11

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in build Nightly (2014-05-26)
Device: Alcatel One Touch (Android 4.1.2)

Comment 12

[Joni Chan]

We've compiled a list of the most popular Firefox for Android articles as well as the YouTube videos here: https://support.mozilla.org/kb/popular-topics-firefox-android. The "Help" menu item is now pointing to this new page, but we can change it back if you think the product page was better.