1007465 - The .variables-view-edit class in widgets.inc.css has left padding

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

Left padding is a lie. There is only start padding. Come to think about it, removing that makes absolutely no difference, so let's just get rid of it entirely!

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Brian Grinstead [:bgrins]]

OK, so note to self: this icon can be seen by inspecting an object with getters and setters, like:

var x = { get y() 42, set y(f) "it's a trap" };

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> OK, so note to self: this icon can be seen by inspecting an object with
> getters and setters, like:
> 
> var x = { get y() 42, set y(f) "it's a trap" };

Or easier in the console: inspect({ get y() 42, set y(f) "it's a trap" })

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: vview-edit-hover.gif

There is a weird movement that happens when hovering this icon.   It happens with or without the patch, though.  Just something I noticed

Comment 5

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/8be8ffd358a0

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8be8ffd358a0