1007466 - [Setting] DSDS related panels can't work when testing on Nightly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

When I want to test DSDS related panels on settings app, it can't work on Nightly because something broken in our desktop_helper.

We would get this error message from log - "JavaScript error: http://settings.gaiamobile.org:8080/js/connectivity.js, line 44: wifiManager is undefined".

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I am currently working on it because I found the root cause.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Error Log :

---
desktop-helper: +++ loading scripts for app: chrome://browser/content/devtools/framework/toolbox.xul
desktop-helper: +++ loading scripts for app: http://settings.gaiamobile.org:8080/
desktop-helper: loading ffos_runtime.js...
desktop-helper: loading lib/bluetooth.js...
desktop-helper: loading lib/cameras.js...
desktop-helper: loading lib/mobile_connection.js...
desktop-helper: loading lib/icc_manager.js...
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "iccManager.iccId is undefined" {file: "chrome://desktop-helper.js/content/data/lib/icc_manager.js" line: 99}]'[JavaScript Error: "iccManager.iccId is undefined" {file: "chrome://desktop-helper.js/content/data/lib/icc_manager.js" line: 99}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
desktop-helper: +++ loading scripts for app: chrome://browser-helper.js/content/panel/index.html
---

How can we call push() on an undefined property xD.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8419155 [details] [review]
patch on master

Kevin,

can you help me review this one line change :P ?

thx !

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8419155 [details] [review]
patch on master

Seems simple enough, thanks!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks ! 

Merged into Gaia/master: 68f7b3d4c3734a699b053cc897c1d11b8326fb93