Closed
Bug 1007469
Opened 10 years ago
Closed 10 years ago
copy-build-stage-manifest should depend on $(XULRUNNER_BASE_DIRECTORY)
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S2 (23may)
People
(Reporter: yurenju, Assigned: eragonj)
Details
(Whiteboard: [good first bug][mentor=yurenju][mentor-lang=zh][p=1])
Attachments
(1 file)
since |copy-build-stage-manifest| uses run-js-command, it should depend on $(XULRUNNER_BASE_DIRECTORY) for javascript runtime.
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [good first bug][mentor=yurenju][mentor-lang=zh]
|
Assignee | |
Comment 1•10 years ago
|
||
I can try it as my good-first bug in building system :D
Assignee: nobody → ejchen
|
|
Reporter | |
Comment 2•10 years ago
|
||
\o/
|
|
Assignee | |
Comment 3•10 years ago
|
||
Yuren, It seems that this target has been removed to a new one by George yesterday. (https://github.com/mozilla-b2g/gaia/commit/7cd746cf8fe292a161203e50caf4093129397223) Maybe we have to fix `copy-build-stage-data` instead ?!
Flags: needinfo?(yurenju.mozilla)
|
|
Reporter | |
Comment 4•10 years ago
|
||
yes, you should, and luckly George didn't fix this issue on his pr so this bug is still valid, so please fix it :D
Flags: needinfo?(yurenju.mozilla)
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [good first bug][mentor=yurenju][mentor-lang=zh] → [good first bug][mentor=yurenju][mentor-lang=zh][p=1]
Target Milestone: --- → 2.0 S2 (23may)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Hi Yurenju, can you help me review this one-line patch !? Thanks :)
Attachment #8422873 -
Flags: review?(yurenju.mozilla)
|
|
Reporter | |
Comment 6•10 years ago
|
||
Comment on attachment 8422873 [details] [review] patch on master r=yurenju, thanks for your contribution!
Attachment #8422873 -
Flags: review?(yurenju.mozilla) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Thanks Yurenju ! Merged into Gaia/master : 10e4bc8a1760bfb66d1e63c881ce4b7f0d1b9755
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•