1007485 - manifest.webapp shoud not be localized in en-US if LOCALE_BASEDIR/en-US exists

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

from bug 968666 comment 17, Pike mentioned manifest shoud not be overwrote if LOCALES_BASEDIR/en-US exists.

(In reply to Axel Hecht [:Pike] from bug 968666 comment #17)
> In multilocale.js, it looks like localizeManifest would overwrite the title
> and description for en-US with the value in en-US, if that was locally
> present? Doesn't sound right. Can you check what happens if a localizer has
> a partial translation of a manifest.properties? Like, description is there,
> but name isn't.

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/21172

George, could you review this pull request?

Pike, this pr will prevent take translation from LOCALE_BASEDIR/en-US, I would like to have your feedback to ensure that is what we want for l10n

Thanks, George, Pike!

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8447907 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/21172

I think stas has a better overview there these days than me, redirecting the request.

The intent sounds good, though.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8447907 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/21172

Some nits in github.
r=gduan.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

review comments have been addressed. waiting for feedback.

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 8447907 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/21172

Sorry for the wait.  f=me, the patch looks good.  If I understand the intent correctly, this is done to save CPU cycles and IO?  en-US/*/manifest.properties files should be generally in sync with manifest.webapp contents, shouldn't they?

Comment 6

[Axel Hecht [:Pike]]

The properties files are totally fine to be out of sync, in particular on 2.1 given that gaia-l10n corresponds to 2.0 right now.

Comment 7

[Staś Małolepszy :stas]

Ah, right. That makes sense, thanks Axel!

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

try server

https://tbpl.mozilla.org/?rev=39fe001f5e6ab49e319486cb4655f27d9f0ce72c&tree=Gaia-Try

Comment 9

[Axel Hecht [:Pike]]

We seem to hit this issue in bug 1028808. What are the next steps to land this?

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I forgot to land it, rebase and push to try again then we can land if got all green.

https://tbpl.mozilla.org/?rev=e029a828b74e5c7016bca8113aaa1c1cb0481031&tree=Gaia-Try

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged since we always got red on Gij.

https://github.com/mozilla-b2g/gaia/commit/d29773d2a011825fd77d1c0915a96eb0911417b6