1007511 - allow test data to specify y-axis units

Status: RESOLVED FIXED

(Datazilla Graveyard :: User interface, defect, P1)

Description

[Dave Huseby [:huseby]]

Allow us to change the units for the y axis on the graphs as well now that we're starting to store both memory, frame rates, and power consumption in there as well as milliseconds (the current default).

Comment 1

[Jonathan Eads ( :jeads )]

I'm adding a data file to the datazilla repository that will map Y axis units to what the UI calls "Tests". I think this will be the most sensible way of doing this since there should be a 1 to 1 relationship between the Test and the type of units on the Y-axis, that way we don't have to send the units with every individual test datum. The complete list of tests submitted to b2g_perftest_1 is listed below, I know many of these tests are no longer actively used so those can be ignored. I need to identify which test names do not have the default unit type of milliseconds and what the correct units to associate are. If there are regex or string matching patterns that would make sense here let me know, like all the tests with the string 'memory' in their name should have units of type x.

All b2g perf test names
--------------------------------------
Dialer/callLog_rendering_time_>_call-log-ready
Dialer/callLog_rendering_time_>_first-chunk-ready
Overfill_Settings_Scroll_>_overfills
above-the-fold-ready
bookmark_memory
browser_memory
calendar_memory
camera_load_end
camera_memory
clock_memory
cold_load_time
communications/contacts_memory
communications/dialer_memory
communications/ftu_memory
costcontrol_memory
email_memory
emergency-call_memory
endurance_add_contact
endurance_add_delete_contact
endurance_add_delete_event
endurance_add_edit_contact
endurance_add_edit_event
endurance_add_event
endurance_background_apps
endurance_browser_wifi
endurance_camera_photo
endurance_camera_video
endurance_camera_viewfinder
endurance_fmradio_play
endurance_gallery_camera
endurance_gallery_flick
endurance_launch_phone
endurance_lock_screen
endurance_set_alarm
endurance_settings
endurance_sms_send_receive
endurance_video_playback
findmydevice_memory
fm_memory
fps
fps_hwc
gallery_load_end
gallery_memory
messages_time_to_paint
music_memory
operatorvariant_memory
phone_time_to_paint
rendering_WiFi_list_>_moz-app-loaded
rendering_WiFi_list_>_moz-app-visually-complete
rendering_WiFi_list_>_moz-content-interactive
rendering_WiFi_list_>_settings-panel-wifi-ready
rendering_WiFi_list_>_settings-panel-wifi-visible
rendering_time_>_first_chunk
rendering_time_>_last_chunk
settings_memory
settings_time_to_paint
sms_memory
startup-path-done
startup_>_above-the-fold-ready
startup_>_fm-radio-enabled
startup_>_init-finished
startup_>_load
startup_>_media-enumerated
startup_>_moz-app-loaded
startup_>_moz-app-visually-complete
startup_>_moz-chrome-dom-loaded
startup_>_moz-chrome-interactive
startup_>_moz-content-interactive
startup_>_objects-init-finished
startup_>_startup-path-done
startup_>_will-render-threads
startup_time
time_to_load_end
video_memory

Comment 2

[Jonathan Eads ( :jeads )]

I went ahead and implemented this. A new json file is available in the datazilla repository to control the y-axis units https://github.com/mozilla/datazilla/blob/master/datazilla/settings/data/test_units.json.

I'm not sure what the correct units are but this is what I'm starting out with:

{
    "default": { "contains":false, "label":"Run Time (milliseconds)" },
    "_memory":{ "contains":true, "label":"Memory (KB)" }
}

The key in this json structure should exactly match one of the test names in the previous comment or utilize the "contains" boolean in which the key should contain a string to match against the test name. The current entry for "_memory" will match all of the test names with the "_memory" string in them giving them the y-axis label of "Memory (KB)". If this is incorrect please let me know and I will change it.

bookmark_memory
browser_memory
calendar_memory
camera_memory
clock_memory
communications/contacts_memory
communications/dialer_memory
communications/ftu_memory
costcontrol_memory
email_memory
emergency-call_memory
findmydevice_memory
fm_memory
gallery_memory
music_memory
operatorvariant_memory
settings_memory
sms_memory

Comment 3

[Dave Huseby [:huseby]]

_memory is in KB