100753 - [REGRESSION] Bullet indents but doesn't return to original position

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[shrirang khanzode]

forked from bug 97797

steps:
launch composer
click bullet list item
click right indent button
click left indent button

Expected results

Bullet indents, then returns to its original position

Actual results

Bullet indents, and doesn't return to its original position

Comment 1

[Hong Kwon]

This is, I believe, the more serious variant of bug 97797.  The average user
will try to create a bullet list and indent it to the right level and the bullet
doesn't indent, but instead drops down a few pixels while the text insertion
point moves.

The workaround is to type text and THEN indent the bullet, but this is truly
annoying and counterintuitive.  This is a REGRESSION.  We must fix this or
Composer will have lower quality than the previous release.

Comment 2

[sol]

I agree with Hong's assessment that this is a very visible regression, therefore
I added regression to the keywords and PDT to the status whiteboard.

Comment 3

[sujay]

adding QAHP

Comment 4

[chris hofmann]

joe,  any eta on a fix for this?

Comment 5

[Joe Francis]

Attachment: patch to editor/base/nsHTMLEditRules.cpp

Comment 6

[Joe Francis]

ETA is now.  I just need reviews.  This is change is pretty low risk, as it is
the same fix as in 97797, just applied in a WillOutdent() instead of WillInddent().

Comment 7

[kinmoz]

Comment on attachment 50867 [details] [diff] [review]
patch to editor/base/nsHTMLEditRules.cpp

sr=[e-mail]

Just fix the indentation for this change:

-    res = NS_NewISupportsArray(getter_AddRefs(arrayOfNodes));
+   // make our array contain just this li node
+   res = NS_NewISupportsArray(getter_AddRefs(arrayOfNodes));
     if (NS_FAILED(res)) return res;

Comment 8

[Kathleen :Brade]

Comment on attachment 50867 [details] [diff] [review]
patch to editor/base/nsHTMLEditRules.cpp

r=brade

Comment 9

[Jaime Rodriguez, Jr.]

check it in today - PDT+

Comment 10

[Joe Francis]

fix landed on 094 branch

Comment 11

[sujay]

verified in 9/28 branch.

looks good.

Comment 12

[sujay]

verified on 10/26 trunk....there is a regression now...but its in
layout..

1) launch netscape
2) launch composer
3) click bulleted list
4) right indent
5) left indent

notice the bullet jumps down  a bit...The source is the same
as before when this was working, so Joe deduced that this is a layout
issue.

http://bugzilla.mozilla.org/show_bug.cgi?id=107041