Closed Bug 1007530 Opened 10 years ago Closed 10 years ago

Special categorization for out-of-memory crashes

Categories

(Socorro :: General, task)

x86_64
Windows 7
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: away, Assigned: lars)

References

Details

Attachments

(1 file)

OOM failures have many different stacks, which doesn't work well with our usual approach of bucketing crashes by signature.

It would be helpful to have a way where OOM failures as a whole could be considered "one signature" for some purposes. Then we could do things like correlate with modules, extensions, look at average virtual memory availability, etc.

An initial set of criteria for OOM crashes might be: anything with an OOMAllocationSize annotation, or with any of these in the signature: NS_ABORT_OOM, mozalloc_handle_oom, CrashAtUnhandlableOOM
There are a couple ways to approach this. Lars was thinking it's an opportunity for a generic classifier. I see an opportunity to implement a second signature generation method to apply to OOM failures specifically.
Detailed specification:

A crash should be treated as an OOM crash in any of the following conditions:
* The OOMAllocationSize annotation is present
* The signature contains NS_ABORT_OOM, mozalloc_handle_oom, CrashAtUnhandlableOOM

If the OOMAllocationSize annotation is present:
    If the value is 256k or smaller (262144):
        The signature should be "OOM | Small"
    If the value is larger than 256k:
        The signature should be "OOM | Large | <C++Signature>"
Else:
    The signature should be "OOM | Unknown | <C++Signature>"

The original c++ signature should be available in the processed crash and to supersearch.

In the final outcome, we will be able to:
* Get the rate of all OOM crashes
* look at known-small crashes (engineering action: OOM analysis)
* look at known-large crashes (engineering action: use a fallible allocator)
* look at unknown-size OOM crashes (engineering action: annotate the size)
Assignee: nobody → lars
Target Milestone: --- → 88
Attachment #8430860 - Flags: review?(benjamin)
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6881b36682abf0041db8841cc6743932f6bb1fdf
Merge pull request #2067 from twobraids/oomsig

Fixes Bug 1007530 - OOM signature manipulations
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8430860 - Flags: review?(benjamin)
this will go into Socorro staging today - once it proves itself, it will go into production later this week.
Blocks: 1024627
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: