1007535 - [B2G][Emulator] Support UNSOLICITED_ON_USSD in emulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Edgar Chen [:edgar]]

Add support for UNSOLICITED_ON_USSD in emulator, and we can write some test case for it.

Please see,
1. RIL_UNSOL_ON_USSD [1]
2. AT+CUSD [2]

[1] https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/telephony/ril.h#L3440-L3461
[2] TS 27.007 session 7.15

Comment 1

[Edgar Chen [:edgar]]

My idea is adding a console command to generate USSD UNSOLICITED response.

Comment 2

[Edgar Chen [:edgar]]

WIP branch:
https://github.com/EdgarChen/platform_hardware_ril/commits/bug_1007535/unsol_ussd
https://github.com/EdgarChen/platform_external_qemu/commits/bug_1007535/unsol_ussd

Comment 3

[Edgar Chen [:edgar]]

Attachment: platform_hardware_ril: PR#36

Comment 4

[Edgar Chen [:edgar]]

Attachment: platform_external_qemu: PR #81

Will attach test script later.

Comment 5

[Edgar Chen [:edgar]]

Attachment: Marionette test for ussd received event, v1

Comment 6

[Edgar Chen [:edgar]]

Test with qemu/ril patches: https://tbpl.mozilla.org/?tree=Try&rev=8f268b52ec41

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8419950 [details] [review]
platform_hardware_ril: PR#36

Hi Vicamo, could you help to review this? Thank you.

Comment 8

[Edgar Chen [:edgar]]

Attachment: Marionette test for ussd received event, v2

Comment 9

[Edgar Chen [:edgar]]

Landing sequence:
1). external/qemu and hardware/ril pull requests
2). Gecko patch

Comment 10

[Edgar Chen [:edgar]]

Attachment: Marionette test for ussd received event, v3

Oh, I uploaded a wrong patch (v2), attach correct one (v3) now, sorry for the noise.

Comment 11

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8419950 [details] [review]
platform_hardware_ril: PR#36

Some nits to be addresses.  Thank you.

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8419950 [details] [review]
platform_hardware_ril: PR#36

After more offline discuss, network initiated USSD responses are of format "+CUSD: <m>[,<str>,<dcs>]", which follows <dcs> and <str> must appear as a pair.  Besides, that <str> is a USSDstring, not plain text.  In order to be more spec conforming, these differences have to be resolved first.

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8419999 [details] [review]
platform_external_qemu: PR #81

Per comment 16, we need a way to specify <dcs> on console command interface and convert input string to corresponding format accordingly.

Comment 14

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

defer to sprint3 as it's not resolved yet.

Comment 15

[Edgar Chen [:edgar]]

According to (In reply to Vicamo Yang [:vicamo][:vyang] from comment #12)
> Comment on attachment 8419950 [details] [review]
> platform_hardware_ril: PR#36
> 
> After more offline discuss, network initiated USSD responses are of format
> "+CUSD: <m>[,<str>,<dcs>]", which follows <dcs> and <str> must appear as a
> pair.  Besides, that <str> is a USSDstring, not plain text.  In order to be
> more spec conforming, these differences have to be resolved first.

Hmm, The message in RIL_UNSOL_ON_USSD is a plain text (in UTF-8) [1], so we need to decode "USSDstring" based on "Cell Broadcast Data Coding Scheme" in reference-ril. There is a lot of work needed to be done in reference-ril.

[1] https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/telephony/ril.h#L3440-L3462

Comment 17

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Edgar,
I revisited comment 13 and comment 15 again, and want to raise a question here. I understand the concern in comment 13 and comment 15 is for 3gpp compliance. However, as in our ussd session gecko code, we don't handle encoding/decoding that I am concerned this compliance with complexity in implementation doesn't provide us a lot value. IMHO your current WIP is prefect enough to help our testing. If we are concerned the "compliance" do you think it's acceptable that we introduce a new AT-command by our own that takes plan text as a parameter?

Comment 18

[Edgar Chen [:edgar]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #17)
> Hi Edgar,
> I revisited comment 13 and comment 15 again, and want to raise a question
> here. I understand the concern in comment 13 and comment 15 is for 3gpp
> compliance. However, as in our ussd session gecko code, we don't handle
> encoding/decoding that I am concerned this compliance with complexity in
> implementation doesn't provide us a lot value. IMHO your current WIP is
> prefect enough to help our testing. If we are concerned the "compliance" do
> you think it's acceptable that we introduce a new AT-command by our own that
> takes plan text as a parameter?

Thanks for raising this. 
I agree with you that following spec in this case doesn't provide us a lot value. Introducing our own AT-command sounds good to me as we won't break the 3gpp standard. Will update the PR.

Comment 19

[Edgar Chen [:edgar]]

Attachment: [platform_external_qemu:b2g-kitkat] PR #173

Comment 20

[Edgar Chen [:edgar]]

Attachment: [platform_hardware_ril:b2g-kitkat] PR #74

Comment 21

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=40f1ed6837d2&group_state=expanded&exclusion_profile=false

Comment 22

[Edgar Chen [:edgar]]

Comment on attachment 8689950 [details] [review]
[platform_external_qemu:b2g-kitkat] PR #173

Hi Hsinyi, may I have your review for this PR? I introduce a new AT-Command with 'M' prefix which takes plan text as a ussd message. Thank you.

Comment 23

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8689950 [details] [review]
[platform_external_qemu:b2g-kitkat] PR #173

Looks good to me, thank you!

Comment 24

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8689956 [details] [review]
[platform_hardware_ril:b2g-kitkat] PR #74

Left a minor comment on github.

r=me thank you.

Comment 25

[Edgar Chen [:edgar]]

Attachment: [platform_hardware_ril:b2g-kitkat] PR #75

I mis-deleted the local branch which is used for PR #74, so I create a new PR again.

Comment 26

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8420740 [details] [diff] [review]
Marionette test for ussd received event, v3

Mark this as obsolete as this patch doesn't work on the latest main trunk due to WebAPI changes.

Comment 27

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 0001-test-example-for-bug-1007535.patch

This is an example to show how to use the new command Edgar introduced in Telephony marionette-webapi tests.

Comment 28

[pelloux]

I may be wrong but I don't see how one can send null/empty message using the newly added |ussd unsol| command?

Comment 29

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8689950 [details] [review]
[platform_external_qemu:b2g-kitkat] PR #173

Reverting the r+ flag per comment 28. I also left a comment on github. Thank you.

Comment 30

[Edgar Chen [:edgar]]

(In reply to pierre-eric from comment #28)
> I may be wrong but I don't see how one can send null/empty message using the
> newly added |ussd unsol| command?

I have updated the PR, now you can send null/empty message by |ussd unsol <type>|. Could you try again?
Thank you.

Comment 31

[pelloux]

(In reply to Edgar Chen [:edgar][:echen] from comment #30)
> I have updated the PR, now you can send null/empty message by |ussd unsol
> <type>|. Could you try again?

Thanks it's working now.

Comment 32

[Edgar Chen [:edgar]]

(In reply to pierre-eric from comment #31)
> (In reply to Edgar Chen [:edgar][:echen] from comment #30)
> > I have updated the PR, now you can send null/empty message by |ussd unsol
> > <type>|. Could you try again?
> 
> Thanks it's working now.

Since it's working now, may I have your review again, Hsinyi?
Thank you.

Comment 33

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8689950 [details] [review]
[platform_external_qemu:b2g-kitkat] PR #173

works like a charm!

Comment 34

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ddd59a806e2&exclusion_profile=false

Comment 35

[Edgar Chen [:edgar]]

b2g-kitkat:
https://github.com/mozilla-b2g/platform_external_qemu/commit/39bdda3051dd1d96da3ab369bc654290cb8d463c
https://github.com/mozilla-b2g/platform_hardware_ril/commit/c0dd0098328f3992e1ca09d6d4355729243863d5