1007542 - Add Phone Number into FROM Field of MMS Header when transmitting MMS PDU to network.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

*** This is a duplicated bug to Bug 995486 ***

I'd like describe the handling of FROM field in MMS header more specifically in this bug.

According to the |From| field defined in |6.1.1 Send Request| & |6.7.2 PDU Read Report 
| of OMA MMS Encapsulation Protocol [2]:
"
 The originator MMS Client MUST send either its address or an |Insert-address-token|.
 In case of token, the MMS Proxy-Relay MUST insert the correct address of 
 the originator MMS Client.
"

In current FFOS implementation, 
we choose to fill |Insert-address-token| to leave this to MMS Proxy-Relay.
However, Some Operator not allow to have |Insert-address-token| specified, 
which didn't obey the OMA requirement:
"In case of token, the MMS Proxy-Relay MUST insert the correct address of 
 the originator MMS Client"
(See Bug 995486 for the error reported from VzW network.)

After comparing the implementation in AOSP, we found that in AOSP implementation,
the line number will be used to replaced |Insert-address-token| if available. [1][2]

The solution for this bug is to specified the phone number into FROM field to
increase the compatibility of more carrier.


[1] http://androidxref.com/4.3_r2.1/xref/packages/apps/Mms/src/com/android/mms/transaction/SendTransaction.java#108
[2] http://androidxref.com/4.3_r2.1/xref/packages/apps/Mms/src/com/android/mms/transaction/ReadRecTransaction.java#84

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v1 - Add Phone Number into FROM Field of MMS Header when transmitting MMS PDU to network. r=vyang.

Verify Pass with following UICC:
CHT(Empty MSISDN), 
TMO(MSISDN without international TON), 
CU (MSISDN with international TON).

Comment 2

[jongsoo.oh]

This feature have to apply to v1.4 for commercialization.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

update try server result:
https://tbpl.mozilla.org/?tree=Try&rev=5cc71598af23

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8419235 [details] [diff] [review]
Patch v1 - Add Phone Number into FROM Field of MMS Header when transmitting MMS PDU to network. r=vyang.

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A. This is because some carrier didn't follow the OMA standard when FROM in MMS header is equal to insert-address-token. According to OMA standard, MMS client can either fill the address or the insert-address-token. To be more compatible with more carriers, we filled the address proactively if it's already available in inserted UICC.
User impact if declined: can not get the certificate from carrier.
Testing completed: Yes.
Risk to taking this patch (and alternatives if risky): No
String or UUID changes made by this patch:No

Comment 5

[Preeti Raghunath(:Preeti)]

Approved for 1.4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/9c0299e910bf

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/9c0299e910bf

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c0299e910bf

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/d017bbb0fd61