1007568 - Follow symlinks when copying apps into STAGE_DIR

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Leila]

Directories under GAIA_APPDIRS might contain symlinks (e.g. outoftree_apps). When copying the symlinked apps into STAGE_DIR without -L option, clear-stage-app will remove the files in the target directory. This issue is seen on second run of "make install/reset-gaia".

The issue appears after bug 999413 was merged.

Comment 1

[Leila]

Attachment: Bug_1007568-Follow-symlinks-when-copying-apps-into-STAGE_DIR.patch

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8419259 [details] [diff] [review]
Bug_1007568-Follow-symlinks-when-copying-apps-into-STAGE_DIR.patch

Leila, your patch looks good so r=yurenju, and please send a pull request to mozilla-b2g/gaia on github and wait result of travis-ci is green, then I will merge that pr.

thanks for your contribution!

Comment 3

[Leila]

Attachment: pull request for fixing Bug 1007568.

The Travis CI build passed.

Comment 4

[Jan Keromnes [:janx]]

Thank you Leila, merged in https://github.com/mozilla-b2g/gaia/commit/4d7952a4.

Congratulations on your first patch!

Comment 5

[Jan Keromnes [:janx]]

Comment on attachment 8421687 [details] [review]
pull request for fixing Bug 1007568.

r=yurenju

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Reverted for OSX bustage.
https://github.com/mozilla-b2g/gaia/commit/7973e06dc278f67b4109ac3c33020ed086f0d042

https://tbpl.mozilla.org/php/getParsedLog.php?id=39743357&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=39745749&tree=B2g-Inbound

Comment 7

[Leila]

Attachment: Bug_1007568-Follow-symlinks-when-copying-apps-into-STAGE_DIR_osx_tested.patch

Replaced with -LR to support OSX build too.

Comment 8

[Jan Keromnes [:janx]]

Comment on attachment 8424577 [details] [diff] [review]
Bug_1007568-Follow-symlinks-when-copying-apps-into-STAGE_DIR_osx_tested.patch

Review of attachment 8424577 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fixed patch Leila! I'm not the right person to review this, but since the new version is close enough to the previous, r+ with r=yurenju.

Also, for changes in Gaia there is no need to upload patches here before opening a pull request. The whole review cycle can happen in the pull request.

Please open a pull request with your new change, link it to this bug again, set the r+ flag for yurenju, and use the checkin-needed keyword when you feel confident that the tests will pass. Good luck!

Comment 9

[Jan Keromnes [:janx]]

On second thought, you can just push -f to your current pull request branch `copy-symlink`, that will update the pull request currently linked to this bug and it already has r+.

Be sure to mark the other patches as obsolete when adding `checkin-needed`, so as not to confuse the sheriff who will come to land your patch.

Comment 10

[Leila]

Attachment: pull request for fixing Bug 1007568

Comment 11

[Leila]

https://travis-ci.org/mozilla-b2g/gaia/jobs/25522840
travis didn't pass but the error doesn't look like to be related to my commit, how can I regrigger the test? or should I create a new pull request?

Comment 12

[Jan Keromnes [:janx]]

The failure does look like an unrelated intermittent failure. I've re-triggered the job for you, but an easy way to do that is to rebase your commit on top of gaia/master and to `git push -f` it to your pull-request branch again.

Comment 13

[Leila]

passed : https://travis-ci.org/mozilla-b2g/gaia/jobs/25522840

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/d04280124a50efa3f80b3252a33d042ecac0d624