NS_ConvertASCIItoUCS2(char), NS_ConvertUTF8toUCS2(char), and NS_ConvertUCS2toUTF8(PRUnichar) are silly. Why should people use an ns[C]AutoString to do a conversion that could be done with a cast? (And furthermore, a character in UTF8 can't always be represented in a single |char|.) If someone really wants to do something like this they could use nsDependent[C]String(&myChar, 1), but would anyone really want to? Maybe one of us should try removing those constructors and see if anyone uses these...
Will have a patch for this soonish. Discovered there's exactly one user, which we can fix in place.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.6
I'll compile this on my Win and Mac boxen and see if anything platform specific pops up.
Comment on attachment 50271 [details] [diff] [review] Seems we can safely remove this. r=dbaron (assuming you've done the testing above)
Attachment #50271 - Flags: review+
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.