Closed
Bug 1007645
Opened 10 years ago
Closed 10 years ago
Consider disabling background color filter for suggested sites
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 32
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(3 files)
Right now, we apply a color filter on the top sites' background color so that they are not too bright. The background color is only visible when we display favicons in the grid item. However, we probably want to disable the color filter for suggested sites.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Ian, do we want to keep the same behaviour for both favicons and suggested sites? The first image shows suggested sites with the same color filter as favicons. The second shows suggested sites without the color filtering. My take on this is that we should not use color filters so that the end result is more predictable. We can always use dimmed colors explicitly if we want. Ian, thoughts?
Flags: needinfo?(ibarlow)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8419444 [details] [diff] [review] Don't use opacity filter on suggested sites' background (r=wesj) And only use the opacity filter when we're displaying favicons.
Attachment #8419444 -
Flags: review?(wjohnston)
Comment 6•10 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #3) > Ian, do we want to keep the same behaviour for both favicons and suggested > sites? The first image shows suggested sites with the same color filter as > favicons. The second shows suggested sites without the color filtering. > > My take on this is that we should not use color filters so that the end > result is more predictable. We can always use dimmed colors explicitly if we > want. Ian, thoughts? I agree. We want a little more control over the tile colour for suggested sites, so pulling out the colour filters for these makes sense to me.
Flags: needinfo?(ibarlow)
Assignee | ||
Updated•10 years ago
|
Attachment #8419444 -
Flags: review?(wjohnston) → review?(mark.finkle)
Updated•10 years ago
|
Attachment #8419444 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/191d41406211
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/191d41406211
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•