1007675 - [SMS] Fuzzy icons on high res devices

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Wilson Page [:wilsonpage]]

Icons look fuzzy on high-res screens (Flame, Nexus4). Should be replaced with high-res PNGs or vector icon-font (see Camera as example).

IMO icon font is the best solution. Implement and forget. Plus when size or colors change devs don't have to go back to the designer for new assets.

Comment 1

[Julien Wajsberg [:julienw]]

I'd agree with you on the rationale.

However we _do_ have icons for each screen resolutions. Are you sure you're flashing with the correct environment variable? I think you need to use "GAIA_DEV_PIXELS_PER_PX=1.5" or something.

See https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking#High_resolution_image_assets

I'd say it's a WORKSFORME, but please check before !

Comment 2

[Wilson Page [:wilsonpage]]

I didn't know that was a thing! Can't we move towards vectors and forget about device pixels and forget about @1x @1.5x @2x?

Comment 3

[Julien Wajsberg [:julienw]]

I think this is a general goal but this is not my call.

I don't know if the visual team is currently settled on icon vs svg.
I also don't know if we have a meta bug for this. Anthony, do you know?

Comment 4

[Chris Lord [:cwiiis]]

I am using GAIA_DEV_PIXELS_PER_PX=1.5, but I still see fuzzy icons in various places. This seems to be something that regresses frequently for me, it was ok a couple of days ago, now 1.4 and master are broken for me...

Is there a common issue that reoccurs that causes this breakage? Or am I the only one experiencing that and there's something up with my build tree?

Comment 5

[:gerard-majax]

I don't reproduce this on my Flame with a build from a couple of hours ago.

Comment 6

[Julien Wajsberg [:julienw]]

I _think_ you need to set the env variable when you generate the profile. If the profile is already generated it won't have any effect.
(or something like this)

try "make clean" and then try again.

Comment 7

[Chris Lord [:cwiiis]]

So it seems that using the build.sh and flash.sh scripts means that a lot of my .userconfig isn't respected... However, if I source my .userconfig and run make clean && make install-gaia manually, it works as expected.

Perhaps we could look into fixing build.sh/flash.sh in this bug?

Comment 8

[Julien Wajsberg [:julienw]]

QA would ask you to file another bug and close this one ;)

Comment 9

[Chris Lord [:cwiiis]]

Yeah, you're right, I was being lazy :)

Comment 10

[Anthony Ricaud (:rik)]

We can't use SVG yet because of performance problems, see bug 999931.