Closed
Bug 1007722
Opened 12 years ago
Closed 12 years ago
Add helpers for special JS refcounts in the cycle collector
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
4.50 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Olli points out that these weird checks for a refcount of 0 we have sprinkled around are confusing, so we should add a helper function like IsGrayJS() to PtrInfo. A similar one that null checks mParticipant would also be nice.
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → continuation
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #8422044 -
Flags: review?(bugs)
| Assignee | ||
Comment 2•12 years ago
|
||
Attachment #8422044 -
Attachment is obsolete: true
Attachment #8422044 -
Flags: review?(bugs)
Attachment #8422046 -
Flags: review?(bugs)
Updated•12 years ago
|
Attachment #8422046 -
Flags: review?(bugs) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Thanks for the suggestion, this is a lot nicer.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b78563c4462
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•