1007734 - UpdatePanZoomControllerTree() could leave an APZC with a stale parent pointer

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Botond Ballo [:botond]]

Quoting Kats from https://bugzilla.mozilla.org/show_bug.cgi?id=961289#c73

"It occurs to me that in the case where the apzc is recycled (i.e. code flow didn't take the |if (newApzc)| branch above) and also we go through the |mRootApzc = apzc| branch, then it's possible for apzc->GetParent() to be some stale pointer. I don't think this ever happens in practice but maybe we should explicitly null out the parent pointer when setting mRootApzc to apzc."

Comment 1

[Botond Ballo [:botond]]

Attachment: bug1007734.patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8419503 [details] [diff] [review]
bug1007734.patch

Review of attachment 8419503 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! :)

Comment 3

[Botond Ballo [:botond]]

https://tbpl.mozilla.org/?tree=Try&rev=54bb64c02557

Comment 4

[Botond Ballo [:botond]]

Try push is green but inbound is still (or again) closed, re-flagging as checkin-needed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/825990d5d74d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/825990d5d74d