Closed Bug 1007788 Opened 10 years ago Closed 10 years ago

Disallow in-source builds of js/src

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: axs, Assigned: axs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Mirror the main m-c tree and disallow in-source builds of js/src.  As per a recent quote on irc, 

<jorendorff>: in-tree builds are nothing but trouble

note that accepting this would allow resolution for bug 1006275 , since it would no longer apply.

try result: https://tbpl.mozilla.org/?tree=Try&rev=1cf83be70e72
Attachment #8419551 - Flags: review?(mh+mozilla)
Attachment #8419551 - Flags: review?(jorendorff)
Comment on attachment 8419551 [details] [diff] [review]
Disallow in-source builds for js/src , same as the main m-c tree

Review of attachment 8419551 [details] [diff] [review]:
-----------------------------------------------------------------

This is essentially a copy of what we have in toplevel configure.in
Attachment #8419551 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8419551 [details] [diff] [review]
Disallow in-source builds for js/src , same as the main m-c tree

land please!  try result is above; summary: green on linux (incl. SMe) , win64 , linux b2g
Attachment #8419551 - Flags: review?(jorendorff) → checkin?
Attachment #8419551 - Flags: checkin?
Keywords: checkin-needed
Ian, thank you so much for doing this.
https://hg.mozilla.org/mozilla-central/rev/ccb05ff78cfe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: