Closed
Bug 1007788
Opened 10 years ago
Closed 10 years ago
Disallow in-source builds of js/src
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: axs, Assigned: axs)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
2.55 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Mirror the main m-c tree and disallow in-source builds of js/src. As per a recent quote on irc, <jorendorff>: in-tree builds are nothing but trouble note that accepting this would allow resolution for bug 1006275 , since it would no longer apply. try result: https://tbpl.mozilla.org/?tree=Try&rev=1cf83be70e72
Assignee | ||
Updated•10 years ago
|
Attachment #8419551 -
Flags: review?(mh+mozilla)
Attachment #8419551 -
Flags: review?(jorendorff)
Comment 1•10 years ago
|
||
Comment on attachment 8419551 [details] [diff] [review] Disallow in-source builds for js/src , same as the main m-c tree Review of attachment 8419551 [details] [diff] [review]: ----------------------------------------------------------------- This is essentially a copy of what we have in toplevel configure.in
Attachment #8419551 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8419551 [details] [diff] [review] Disallow in-source builds for js/src , same as the main m-c tree land please! try result is above; summary: green on linux (incl. SMe) , win64 , linux b2g
Attachment #8419551 -
Flags: review?(jorendorff) → checkin?
Assignee | ||
Updated•10 years ago
|
Attachment #8419551 -
Flags: checkin?
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
Ian, thank you so much for doing this.
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb05ff78cfe
Assignee: nobody → axs
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Removed documentation about in-source builds from https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation
Keywords: dev-doc-complete
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ccb05ff78cfe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•