1007800 - No reviews showing in Marketplace

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Nicole Fong]

Attachment: Screenshot of no reviews page

Repro Steps:
-Open Marketplace
-Change region to Mexico or Brazil 
-Search for Line
-Click to view reviews

Actual: No reviews are shown.  "This app has no reviews"
 
Expected: Reviews should be shown

Produced on Helix v1.3
Build ID: 20140131004001

Comment 1

[Jason Smith [:jsmith]]

I'm not really the right person to assign here - ask Wil for someone from his team to look into this.

Comment 2

[Wil Clouser [:clouserw]]

When we add a new region to the Marketplace it is considered immature and all calculations (like, determining the popularity list) and reviews are based on a worldwide measure.

Once a region gets enough users to start making those calculations locally relevant (for example, there is now enough traffic to actually determine popularity without wild fluctuations) we'll mark that region as mature and it will begin showing more locally relevant results.

Those two regions were marked mature recently and I suspect they are attempting to only show local reviews but failing.  Rob is going to investigate.

Comment 3

[Simon Callan, Telefonica]

Also set your region to UK search for Yelp, Click on reviews you seem to get the same page, Click on reviews again and you get "Oh no! An error occured"

Comment 4

[Rob Hudson [:robhudson]]

(In reply to Wil Clouser [:clouserw] from comment #2)
> Those two regions were marked mature recently and I suspect they are
> attempting to only show local reviews but failing.  Rob is going to
> investigate.

You're right:
https://github.com/mozilla/zamboni/blob/master/mkt/ratings/views.py#L71-L72

It's trying to JOIN on the client_data but there are no reviews that have a client_data_id -- it's always NULL -- which is why it says there are no reviews.

Should we:
a) Show all reviews instead since we don't have the data to associate ratings per region?
b) Start associated ratings per region and attempt to backfill the data by using the IP address?

Comment 5

[Rob Hudson [:robhudson]]

Fixed by removing the region filter for now:
https://github.com/mozilla/zamboni/commit/0d9728f 

See bug 1004788 for associating ratings with regions.

Comment 6

[Rob Hudson [:robhudson]]

(In reply to Rob Hudson [:robhudson] from comment #5)
> See bug 1004788 for associating ratings with regions.

Actually bug 1004680 might make more sense. :)

Comment 7

[Wil Clouser [:clouserw]]

This will go live next Tuesday

Comment 8

[Victor Carciu]

Verified as fixed : http://screencast.com/t/5VCvx9KY8v

Comment 9

[marcos.gallego]

hi guys, this is still not working for Colombia

thanks!

Marcos

Comment 10

[Wil Clouser [:clouserw]]

It will go live tomorrow

Comment 11

[marcos.gallego]

thanks wil, I had not seen your previous comment saying it was going live on Tuesday