Closed
Bug 1007813
Opened 10 years ago
Closed 10 years ago
forward declaration of CreateEncodedCertificate doesn't match its definition
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: keeler, Assigned: keeler)
References
Details
Attachments
(1 file)
1.72 KB,
patch
|
mmc
:
review+
|
Details | Diff | Splinter Review |
pkixtestutil.h: 73 SECItem* CreateEncodedCertificate(PLArenaPool* arena, long version, 74 SECOidTag signature, long serialNumber, 75 const char* issuerASCII, PRTime notBefore, 76 PRTime notAfter, const char* subjectASCII, 77 /*optional*/ SECItem const* const* extensions, 78 /*optional*/ SECKEYPrivateKey* issuerPrivateKey, 79 SECOidTag signatureHashAlg, 80 /*out*/ ScopedSECKEYPrivateKey& privateKey); pkixtestutil.cpp: 624 SECItem* 625 CreateEncodedCertificate(PLArenaPool* arena, long version, 626 SECOidTag signature, long serialNumber, 627 const SECItem* issuerNameDER, PRTime notBefore, 628 PRTime notAfter, const SECItem* subjectNameDER, 629 /*optional*/ SECItem const* const* extensions, 630 /*optional*/ SECKEYPrivateKey* issuerPrivateKey, 631 SECOidTag signatureHashAlg, 632 /*out*/ ScopedSECKEYPrivateKey& privateKey) In the forward declaration, the issuerName and subjectName arguments are const char*, whereas in the definition they're const SECItem*.
![]() |
Assignee | |
Comment 1•10 years ago
|
||
![]() |
Assignee | |
Updated•10 years ago
|
Attachment #8419580 -
Flags: review?(brian) → review?(mmc)
Updated•10 years ago
|
Attachment #8419580 -
Flags: review?(mmc) → review+
![]() |
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a515c1d5a21
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a515c1d5a21
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•