1007813 - forward declaration of CreateEncodedCertificate doesn't match its definition

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

pkixtestutil.h:
73 SECItem* CreateEncodedCertificate(PLArenaPool* arena, long version,
74                                   SECOidTag signature, long serialNumber,
75                                   const char* issuerASCII, PRTime notBefore,
76                                   PRTime notAfter, const char* subjectASCII,
77                      /*optional*/ SECItem const* const* extensions,
78                      /*optional*/ SECKEYPrivateKey* issuerPrivateKey,
79                                   SECOidTag signatureHashAlg,
80                           /*out*/ ScopedSECKEYPrivateKey& privateKey);

pkixtestutil.cpp:
624 SECItem*
625 CreateEncodedCertificate(PLArenaPool* arena, long version,
626                          SECOidTag signature, long serialNumber,
627                          const SECItem* issuerNameDER, PRTime notBefore,
628                          PRTime notAfter, const SECItem* subjectNameDER,
629                          /*optional*/ SECItem const* const* extensions,
630                          /*optional*/ SECKEYPrivateKey* issuerPrivateKey,
631                          SECOidTag signatureHashAlg,
632                          /*out*/ ScopedSECKEYPrivateKey& privateKey)

In the forward declaration, the issuerName and subjectName arguments are const char*, whereas in the definition they're const SECItem*.

Comment 1

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Attachment: patch

Comment 2

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a515c1d5a21

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7a515c1d5a21