Closed Bug 1007821 Opened 8 years ago Closed 8 years ago

Use image surfaces for transparent content on D3D9

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

This is the MT compositing analog to bug 965096. Doing this will reduce the performance differences between OMTC and MT and will make it easier to add support for Skia.
Attachment #8419583 - Flags: review?(bas)
Blocks: 100770
Blocks: 1007700
No longer blocks: 100770
Assignee: nobody → jmuizelaar
Attachment #8419583 - Flags: review?(bas) → review+
Comment on attachment 8419583 [details] [diff] [review]
avoid-surface.patch

Review of attachment 8419583 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d9/ThebesLayerD3D9.cpp
@@ +457,5 @@
> +TransparentRenderer::End()
> +{
> +  // gfxImageSurface returned from ::Begin() should be released before the
> +  // texture is used. This will assert that this is the case
> +#if 1

nit: obviously remove this debug code, in case that wasn't clear :)
(In reply to Bas Schouten (:bas.schouten) from comment #2)
> Comment on attachment 8419583 [details] [diff] [review]
> avoid-surface.patch
> 
> Review of attachment 8419583 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/d3d9/ThebesLayerD3D9.cpp
> @@ +457,5 @@
> > +TransparentRenderer::End()
> > +{
> > +  // gfxImageSurface returned from ::Begin() should be released before the
> > +  // texture is used. This will assert that this is the case
> > +#if 1
> 
> nit: obviously remove this debug code, in case that wasn't clear :)

That code is actually in the tree for OpaqueRenderer. I just copied it from there.
https://hg.mozilla.org/mozilla-central/rev/4b1ea8792496
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.