1007853 - webmaker.org Facebook linting fails spectacularly

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Aki Rose Braun [:akirose]]

Since our mission is to reach as many people as possible, I /suppose/ we should try passing the facebook linter for webmaker.org with some improved meta tags.

Comment 1

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker.org/pull/771

Comment 2

[inactivate account for kate]

Comment on attachment 8433572 [details] [review]
https://github.com/mozilla/webmaker.org/pull/771

Looks good, one suggestion on the current location path. Yay sharing!

Comment 3

[Aki Rose Braun [:akirose]]

Comment on attachment 8433572 [details] [review]
https://github.com/mozilla/webmaker.org/pull/771

I had one more question for you k88 about preventing the duplicate content hit in search engine findings. Left at https://github.com/mozilla/webmaker.org/pull/771#discussion_r13395451 , didn't think to needinfo? you here. Pasted below.

I wanted to make sure the canonical was always `https` without the `www`. Actually, what I *really* want to do to render the canonical is `https://webmaker.org/{{ lang }}/{{ path }}` but I couldn't figure out how to get my hands on a path variable that is guaranteed not to start with lang. This is a problem because if we have two canonicals, one with and one without lang, we could get hit for duplicate content. I explored all the `$route` objects I could find though, and couldn't find what I was looking for. Open to suggestions?

Comment 4

[inactivate account for kate]

Ok, I get it -- what you did works fine ^_^

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/9d31efb74efa2695e305874212e5d29109e55be4
fixes Bug 1007853 - webmaker.org Facebook linting fails spectacularly

https://github.com/mozilla/webmaker.org/commit/479a6e7201ba049124f11e33d3f9cf112940fd3e
Merge pull request #771 from gesa/1007853/share-meta

Bug 1007853 - webmaker.org Facebook linting fails spectacularly