1007865 - [B2G][Contacts] Icon for send SMS button in contact details is misaligned

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
Send SMS icon button on contact details pages appears offset and misaligned. The surrounding button shape around the inner icon cuts off the icon.

Repro Steps:
1) Updated Open C to BuildID: 20140508040203
2) Launch contacts
3) Select any contact that has a phone number set

Actual:
SMS icon in contact details is cut off.

Expected:
SMS icon appears correct.

Environmental Variables:
Device: Open C v2.0 Master M-C Mozilla RIL
BuildID: 20140508040203
Gaia: 1e0574b8f6b8a2a8d9d468878ce2b4c283fc9a84
Gecko: 2a03b34c8953
Version: 32.0a1
Firmware Version: P821A10V1.0.0B06_LOG_DL

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot and logcat

Comment 1

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Issue does NOT occur on 1.4 Cpen C

Result: Send SMS icon appears normal on contact details page

Environmental Variables:
Device: Open C v1.4 Mozilla RIL
BuildID: 20140508000201
Gaia: 4ce973ef0732b0d52cb043210db598aa176b2ce9
Gecko: 16ab7f6b18f8
Version: 30.0
Firmware Version: P821A10V1.0.0B06_LOG_DL

Comment 2

[Brogan Zumwalt [Inactive]]

Issue DOES occur on 2.0 Buri

Result: SMS icon in contact details is cut off.

Environmental Variables:
Device: Buri v2.0 Master M-C Mozilla RIL
BuildID: 20140508040203
Gaia: 1e0574b8f6b8a2a8d9d468878ce2b4c283fc9a84
Gecko: 2a03b34c8953
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Comment 3

[Natalya Kot [:nkot]]

Looking at the screenshot, it's not just SMS icon that is misaligned but also text in Link and Favorites fields.

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 5

[Jose Manuel Cantera]

Comment on attachment 8420083 [details] [review]
patch in github

LGTM, thanks

Comment 6

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/a2556101232ed3b232102448951f2b1f2922ab08

Comment 7

[Noemí Freire (:noemi)]

Already landed in master so clearing 2.0? flag. Thanks!