1007870 - UnicodeDecodeError on Google translate redirect

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect, P2)

Description

[David Larlet [:davidbgk]]

See http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/4720/

When you try to reach the Google translate page for a comment with special chars, it raises a UnicodeDecodeError.

You have to turn the `reviews-translate` flag to 1 in order to reproduce.

Comment 1

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/49867fbd8813ee73bff83c7651513fa85b486f5a

Comment 2

[krupa raj[:krupa]]

https://addons.mozilla.org/de/firefox/addon/video-downloadhelper/reviews/540531/translate/de loads a blank page for me. So, reopening as per magopian's request on IRC.

Comment 3

[David Larlet [:davidbgk]]

Actually it does redirect to Google translate but the content is not loaded because of an unescaped % character, I'll investigate next week.

Comment 4

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/49867fbd8813ee73bff83c7651513fa85b486f5a

Comment 5

[Madalin Cotetiu]

It redirects to google translate but the content is still empty.
Verified in addons-dev.allizom.org on FF29 (Win 7)
link: https://addons-dev.allizom.org/de/firefox/addon/video-downloadhelper/reviews/540531/translate/de
Please see this screencast: http://screencast.com/t/Prt6kDFWh
Reopening.

Comment 6

[David Larlet [:davidbgk]]

There looks to be an issue with Google translate (not) handling the percent (%) character, STR:

1. Go to https://translate.google.com/
2. Type "3%" in the left textarea
3. Copy the transformed URL (https://translate.google.com/#auto/de/3%25)
4. Paste that URL in another tab
5. The field is not filled with the content

I don't know exactly what is the right thing to do here, we can remove the % char completely but it'll look weird. Or converting it to its textual equivalent but it'll involve translations. Thoughts?

Comment 7

[Wil Clouser [:clouserw]]

Plot twist - it works in chrome! :)

It looks like Firefox is throwing a URIError in the console.  Are we encoding the % correctly?

Comment 8

[David Larlet [:davidbgk]]

If it works in Chrome, isn't it a Firefox bug? :)

Note that with STR the % is encoded by Google translate.

Comment 9

[David Larlet [:davidbgk]]

PR: https://github.com/mozilla/olympia/pull/124 (note that it still doesn't work with Firefox, I filled https://bugzilla.mozilla.org/show_bug.cgi?id=1027527 about that)

Comment 10

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/72579b1c2fd416ac135d676d9dcef424242b6d7e

Comment 11

[Madalin Cotetiu]

(In reply to David Larlet [:davidbgk] from comment #10)
> https://github.com/mozilla/olympia/commit/
> 72579b1c2fd416ac135d676d9dcef424242b6d7e

Should this fix the issue on firefox (the content beeing still empty.)? I am still able to reproduce it in addons-dev.allizom.org in FF30 but not in chrome (Win7)

Comment 12

[David Larlet [:davidbgk]]

Sadly, it won't be fixed in Firefox until 1027527 is fixed. But it should work fine with Chrome now…

Comment 13

[Madalin Cotetiu]

(In reply to David Larlet [:davidbgk] from comment #12)
> Sadly, it won't be fixed in Firefox until 1027527 is fixed. But it should
> work fine with Chrome now…

Thanks David!
It works in chrome: http://screencast.com/t/nYZGeUslQE
I will close this bug and will continue to track the firefox issue in Bug 1027527.