1007881 - The "When Firefox starts: Show my tabs and bookmarks from last time" dropdown is too narrow in the in-content preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Screenshot of bug

See attached screenshot. This is on Windows 8.1 Firefox Nightly 2014-05-08.

Comment 1

[Richard Marti (:Paenglab)]

If it's because the text isn't completely visible, then this should be solved by bug 993369.

Comment 2

[Camelia Badau [:cbadau], Desktop QA]

The fix for bug 993369 doesn't cover all the platforms. This isn't solved by bug 993369, because the problem still persists on Mac OS X.

Comment 3

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: proposed patch

bug 993369 fixes this for windows (and it seems linux too), but for OSX a different -moz-padding-end is needed. This should also fix bug 1007874 (that I'm afraid is a dupe).

Comment 5

[Hernán Rodriguez Colmeiro (:peregrino)]

I tried to debug _why_ the proposed fix actually fixes the issue, but I couldn't find the actual reason why the menuitem needs those extra 4px so that the menulist resizes properly. Is this still a reason to r- the patch?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8427793 [details] [diff] [review]
proposed patch

Review of attachment 8427793 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, I can't reproduce the issue on 10.9.3 non-Retina running Nightly 5-28-2014, but the extra 4px won't hurt and if this fixes the issue for others then let's make this simple change. I would still like to figure out why I can't reproduce it though.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/565d5db8f4d1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/565d5db8f4d1

Comment 9

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Windows 8.1 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 33.0a1 (buildID: 20140610030202).

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Should this fix also be uplifted in Aurora 32.0a2?

Comment 11

[Hernán Rodriguez Colmeiro (:peregrino)]

I think as Jared mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1017594#c4 this won't be enabled for Firefox 32, so no need to uplift.