Closed Bug 1007913 Opened 8 years ago Closed 8 years ago

SVG element in Web Audio Editor should be full size and dynamically resize

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(2 files, 1 obsolete file)

Right now, the SVG element has a set viewBox property, and the dimensions of the svg element needs to match its outer element. Also necessary for changing to side host so that it can be in portrait rather than landscape mode.
Blocks: 994257
Attached image SVG hover
Also, the SVG box hovers over the the tabbar, probably related.
Overlap on tabbar tracked in bug 1007913
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8437974 - Flags: review?(vporof)
Comment on attachment 8437974 [details] [diff] [review]
1007913-svg-in-wae-full-size-dynamic.patch

Review of attachment 8437974 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments below.

::: browser/devtools/webaudioeditor/webaudioeditor.xul
@@ +59,5 @@
>        <box id="web-audio-content-pane" flex="1">
>          <hbox flex="1">
>            <box id="web-audio-graph" class="devtools-responsive-container" flex="1">
>              <vbox flex="1">
> +              <svg id="graph-svg" flex="1"

No more viewBox? I guess this won't scale child nodes anymore, but that's probably ok.

Also, is the "flex" attribute necessary? -moz-box-flex: 1 does the same thing. If not, you should use display: -moz-box in the css. It's better to have both of these properties in the same place.

::: browser/themes/shared/devtools/webaudioeditor.inc.css
@@ +43,2 @@
>    overflow: hidden;
> +  /* Allows full size rendering inside parent */

Nit: I don't think this comment is really necessary.
Attachment #8437974 - Flags: review?(vporof) → review+
Removed comment and redundant attribute -- -moz-box-flex is still needed for this
Attachment #8437974 - Attachment is obsolete: true
Attachment #8438581 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/689a8f84e7f1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.