1007913 - SVG element in Web Audio Editor should be full size and dynamically resize

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Right now, the SVG element has a set viewBox property, and the dimensions of the svg element needs to match its outer element. Also necessary for changing to side host so that it can be in portrait rather than landscape mode.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: SVG hover

Also, the SVG box hovers over the the tabbar, probably related.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Overlap on tabbar tracked in bug 1007913

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1007913-svg-in-wae-full-size-dynamic.patch

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8437974 [details] [diff] [review]
1007913-svg-in-wae-full-size-dynamic.patch

Review of attachment 8437974 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments below.

::: browser/devtools/webaudioeditor/webaudioeditor.xul
@@ +59,5 @@
>        <box id="web-audio-content-pane" flex="1">
>          <hbox flex="1">
>            <box id="web-audio-graph" class="devtools-responsive-container" flex="1">
>              <vbox flex="1">
> +              <svg id="graph-svg" flex="1"

No more viewBox? I guess this won't scale child nodes anymore, but that's probably ok.

Also, is the "flex" attribute necessary? -moz-box-flex: 1 does the same thing. If not, you should use display: -moz-box in the css. It's better to have both of these properties in the same place.

::: browser/themes/shared/devtools/webaudioeditor.inc.css
@@ +43,2 @@
>    overflow: hidden;
> +  /* Allows full size rendering inside parent */

Nit: I don't think this comment is really necessary.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1007913-svg-in-wae-full-size-dynamic.patch

Removed comment and redundant attribute -- -moz-box-flex is still needed for this

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/689a8f84e7f1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/689a8f84e7f1