1007931 - --with-compiler-wrapper duplicates wrapper when it contains backslashes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

with this:
ac_add_options "--with-compiler-wrapper=python2.7 c:\\sccache\\sccache.py"

The build fails during js/src/configure because the wrapper is added twice.

This is due to the test in build/autoconf/wrapper.m4 doesn't work properly when the compiler wrapper contains backslashes.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid compiler wrapper being added twice when it contains backslashes

Comment 2

[Mike Hommey [:glandium]]

Attachment: Replace backslashes with forward slashes in compiler wrapper on windows

Turns out that quite doesn't work properly in other parts of the build system, and the simpler solution is just to normalize slashes.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8419738 [details] [diff] [review]
Replace backslashes with forward slashes in compiler wrapper on windows

Looks good, though a comment would be nice.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44b0d6c49378

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/44b0d6c49378