Closed
Bug 1007942
Opened 10 years ago
Closed 10 years ago
Remove SCCACHE_NO_HTTPS, and rely on "normal" boto config instead
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
2.17 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
While debugging bug 1006954, I found out about the Boto.is_secure boto config which toggles between http and https, which makes the SCCACHE_NO_HTTPS variable useless. Let's remove it.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8419721 -
Flags: review?(mshal)
Comment 2•10 years ago
|
||
Comment on attachment 8419721 [details] [diff] [review] Remove SCCACHE_NO_HTTPS, and rely on "normal" boto config instead >+ if config.has_option('Boto', 'is_secure'): >+ store_with_https = config.getboolean('Boto', 'is_secure') nit: too much indent? :)
Attachment #8419721 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://github.com/glandium/sccache/commit/bc1ae2a50181ca66796d6c93a272b97038e91f93
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → mozilla32
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•