1007988 - Searching through about:home should add searches to searchbar-history

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mike Connor [:mconnor]]

Attachment: addAboutHomeSearchesToFormHistory

In the process of implementing bug 612453, I realized that we don't actually add searches to the searchbar history, which feels like an easy/obvious fix, especially if we're going to use local results in about:home!  I've modified the code from search.xml, but I'm using FormHistory.jsm directly.

Comment 1

[Matthew N. [:MattN]]

Comment on attachment 8419796 [details] [diff] [review]
addAboutHomeSearchesToFormHistory

Review of attachment 8419796 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Note that I'm on vacation until Monday (inclusive) so I won't get to the other search bugs until after that

A test for this would be nice since it's a special case that is easy to overlook in manual testing.

I believe you know about this but FYI just in case: https://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/nsFormAutoComplete.js?rev=669dff46362f#171

Comment 2

[Drew Willcoxon :adw]

This was fixed by bug 612453, but note bug 1060845.