1007992 - Messages now show '<h2>' tags rather than rendering them.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P1)

Description

[Kris Maglione [:kmag]]

This seems to have been caused by the recent Jingo/Jinja2 upgrade. I see it for editor messages, but it probably applies to all other messages as well.

https://people.mozilla.com/~kmaglione/a7402539dcb15938.png

Comment 2

[Mathieu Agopian [:magopian]]

Seems linked to the fix https://github.com/mozilla/olympia-security/commit/41b68cec25872f73d94b2ca78bd8c14a478e8097 for the bug https://bugzilla.mozilla.org/show_bug.cgi?id=835827

Comment 3

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/79f9bf13db949f6fa1a51bfcb6a89636e47581e0

Comment 5

[krupa raj[:krupa]]

verified on dev. See https://www.dropbox.com/s/z4hazc8jt4xwtej/Screenshot%202014-05-09%2012.04.59.png

Comment 6

[Robert Chira [:RobertC]]

This issue is still reproduced on the staging environment

STR:
1. Go to https://addons.allizom.org and login with your account
2. Go to account settings page
3. Click Update account

Expected results:
"Profile updated" message is displayed

Actual results
"<h2> Profile Updated </h2>" is displayed, <h2> is not interpreted as tag, but as text.


Note: This is also happening after creating a collection.

Comment 7

[Yohan Boniface [:ybon]]

Attachment: Screenshot from 2014-05-12 13:44:33.png

Humm, I don't reproduce, neither locally nor on amo. See attachment.
Are your tests from today?

Comment 8

[Robert Chira [:RobertC]]

From your screenshot I can see that you tested on production environment.
I can reproduce the issue on staging only as stated in https://bugzilla.mozilla.org/show_bug.cgi?id=1007992#c6

Comment 9

[Yohan Boniface [:ybon]]

Oh, OK, sorry for the mix, and thanks for the clarification.
Just discussed with Jason, it appears that the commits from Friday (fixing the issue) has not been pushed to stage. This will be done soon.
Given this info, and given that I don't reproduce in local, I think it's fair closing back this issue. Please reopen if you think I'm wrong.

Comment 11

[Iulian Timis]

Verified as fixed in https://addons-dev.allizom.org/ on FF29 (Win 7)
Attaching postfix screenshot.
Closing bug.

Comment 12

[Iulian Timis]

Attachment: postfix_h2_tags.png