toolbar flashes when I delete a mail

VERIFIED FIXED

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: Bienvenu)

Tracking

({perf})

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

724 bytes, patch
Cavin Song
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
toolbar flashes when I delete a mail

I think it's because we are updating commands.  I think bienvenu worked on this
once.  I think he saw that when going from 1 selected item to 0 to 1 again would
cause us to update commands.  in theory, we could avoid that work.

bienvenu, did you log a bug on this already?  maybe you found it when fixing the
problem where the delete toolbar button was disabled?

Updated

17 years ago
QA Contact: esther → sheelar
(Assignee)

Comment 1

17 years ago
sure, it's just the selection goes from 1 to 0 back to 1 again, so we update the
commands for each of those transitions. We may already know in the view that
we're doing a delete, in which case we could perhaps disable the command
updating. I'll look at it in a minute.

Comment 2

17 years ago
Do you think this would have any impact on delete message perf and if so how
much do you think it would be?
Keywords: perf
(Assignee)

Comment 3

17 years ago
yes, it has an impact, but I don't know how much the impact is. It's a fixed
cost and it's worth investigating. Sorry I haven't got around to this - I forgot
because it wasn't assigned to me.
Assignee: sspitzer → bienvenu

Updated

17 years ago
Keywords: nsbeta1
(Assignee)

Comment 4

17 years ago
Created attachment 55944 [details] [diff] [review]
proposed fix
(Assignee)

Comment 5

17 years ago
Can I get some reviews? This fix makes it so we don't update the commands while
the delete is going on, so we don't update commands when there's nothing
selected, and then again when we select a message. So we still do an extra
update, but it doesn't cause any repaints, so it should be faster.
Status: NEW → ASSIGNED
Comment on attachment 55944 [details] [diff] [review]
proposed fix

sr=sspitzer
Attachment #55944 - Flags: superreview+

Comment 7

17 years ago
Comment on attachment 55944 [details] [diff] [review]
proposed fix

r=cavin.
Attachment #55944 - Flags: review+
(Assignee)

Comment 8

17 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
I deleted small to large single messages and there was not tool bar flashing 
while deleting a mail message.  I deleted message from the toolbar.

Verified:
2001-11-15-05 win98, linux, mac os x
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.