Closed Bug 1008029 Opened 10 years ago Closed 9 years ago

Intermittent browser_newtab_update.js | grid status = 1,2,,,,,,, - Got 2,1,,,,,,,, expected 1,2,,,,,,,

Categories

(Firefox :: New Tab Page, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 37
Tracking Status
firefox35 --- wontfix
firefox36 --- fixed
firefox37 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: KWierso, Assigned: ttaubert)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=39320916&tree=Fx-Team
WINNT 6.2 fx-team pgo test mochitest-browser-chrome-1 on 2014-05-08 17:54:02 PDT for push a39f836bb42d

slave: t-w864-ix-033



17:59:58     INFO -  TEST-START | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js
17:59:58     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js | Changing browser inner height from 776 to 794
18:00:00     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js | grid status = 1,,,,,,,,
18:00:02     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js | grid status = 2,1,,,,,,,
18:00:05  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js | grid status = 1,2,,,,,,, - Got 2,1,,,,,,,, expected 1,2,,,,,,,
18:00:05     INFO -  Stack trace:
18:00:05     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 752
18:00:05     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js :: checkGrid :: line 337
18:00:05     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js :: runTests :: line 37
18:00:05     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js :: TestRunner.next :: line 100
18:00:05     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 781
18:00:05     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
18:00:06     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js | grid status = 2,1,3,4,,,,,
18:00:06     INFO -  TEST-INFO | MEMORY STAT vsize after test: 843063296
18:00:06     INFO -  TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 1893662720
18:00:06     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 304107520
18:00:06     INFO -  TEST-INFO | MEMORY STAT heapAllocated after test: 83485940
18:00:06     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_update.js | finished in 7505ms
Component: Tabbed Browser → New Tab Page
This seems to have shot up to top fail status overnight.
Flags: needinfo?(gavin.sharp)
Flags: needinfo?(gavin.sharp) → needinfo?(ttaubert)
Sorry, but the more I look at this, the more it's apparent that it needs to be disabled for the time-being. We're getting at least one failure per push right now it appears. Hopefully it should be easy to debug and re-enable in short order, but I'm disabling it for now.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d36b25ae7289

BTW, not sure if it's relevant or not that this is the last test to run in the directory (I guess we'll see if browser_newtab_unpin.js starts failing next).
Whiteboard: [test disabled][leave open]
Likely a regression from the patches I landed in bug 1077652.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Flags: needinfo?(ttaubert)
Turns out that head.js' whenPagesUpdated() modifies AllPages._pages[] while we iterate over it when updating pages. That only sometimes causes the page that should be updated to be skipped.
Attachment #8544729 - Flags: review?(gijskruitbosch+bugs)
Attachment #8544729 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/6776f88e29be
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Please request Aurora approval on this when you get a chance :)
Flags: needinfo?(ttaubert)
Comment on attachment 8544729 [details] [diff] [review]
0001-Bug-1008029-Fix-intermittent-browser_newtab_update.j.patch

Approval Request Comment
[Feature/regressing bug #]: Introduced with first landing of about:newtab.
[User impact if declined]: No user impact.
[Describe test coverage new/current, TBPL]: This patch fixes an intermittent test failure.
[Risks and why]: Low risk, trivial change.
[String/UUID change made/needed]: None.
Flags: needinfo?(ttaubert)
Attachment #8544729 - Flags: approval-mozilla-aurora?
Attachment #8544729 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.