1008085 - [testing] Add Page Objects and Base Class

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect)

Comment 1

[Pankaj Malhotra (:bitgeeky)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone-tests/pull/1

Added a page objects and base class.
Rest of the objects will be added along with the tests.

Comment 2

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8419952 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone-tests/pull/1

Great start bitgeeky! Just a few comments in the PR to be addressed.

Comment 3

[Pankaj Malhotra (:bitgeeky)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone-tests/pull/1

Addressed the comments on the pull. Please review and let me know if there are any other changes so that I can rebase and squash the commits.

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8420638 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone-tests/pull/1

Comment in the PR.

Comment 5

[Pankaj Malhotra (:bitgeeky)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone-tests/pull/1

Addressed the comment on the pull, Rebased and Squashed the commits. I think its ready for a merge now :-)

Comment 6

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8421133 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone-tests/pull/1

Landed in https://github.com/mozilla/oneanddone-tests/commit/35a7f2df6c8713e9f57eae23797d3b12ed7d9a02

Comment 7

[Rebecca Billings [:rbillings]]

PR closed, marking as verified.