Closed Bug 1008121 Opened 10 years ago Closed 10 years ago

[VDR][Calendarl] Apply Buttons [BB]

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: arnau, Assigned: pivanov)

Details

Attachments

(2 files)

patch for Gaia/master
46 bytes, text/x-github-pull-request
gaye
: review+
arnau
: feedback+
Details | Review
follow-up patch for Gaia/master
46 bytes, text/x-github-pull-request
gaye
: review+
flod
: feedback+
Details | Review 
Add new styles for Buttons, Selects and Input type date/time
Assignee: nobody → arnau
Assignee: arnau → pivanov
Attached file patch for Gaia/master — 
Hey Arnau,
Can you take a look at this? Thanks :)
Attachment #8424656 - Flags: feedback?(arnau)
Attachment #8424656 - Flags: review?(gaye)
Comment on attachment 8424656 [details] [review]
patch for Gaia/master

works great, thanks Pavel!
Attachment #8424656 - Flags: feedback?(arnau) → feedback+
Comment on attachment 8424656 [details] [review]
patch for Gaia/master

LGTM thanks!
Attachment #8424656 - Flags: review?(gaye) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/9ffa2a0b430a01d397c7f6ab4c03b54cedba7ff1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reopening instead of filing a follow-up, because I think you changed things you didn't want to.

You restored cancel-action in bookmarks (removed in bug 1010996), while your patch is about calendar.
Status: RESOLVED → REOPENED
Flags: needinfo?(pivanov)
Resolution: FIXED → ---
grrrr ... rebase problem ... sorry can you r? this follow-up patch?
Attachment #8426073 - Flags: review?(francesco.lodolo)
Flags: needinfo?(pivanov)
Comment on attachment 8426073 [details] [review]
follow-up patch for Gaia/master

I don't think my review counts, but the patch definitely looks good to me.
Attachment #8426073 - Flags: review?(francesco.lodolo) → feedback+
Comment on attachment 8426073 [details] [review]
follow-up patch for Gaia/master

Hey Gareth,
I mess up the rebase ... can you check this one line follow-up patch?
Attachment #8426073 - Flags: review?(gaye)
Comment on attachment 8426073 [details] [review]
follow-up patch for Gaia/master

Looks fine. Thanks!
Attachment #8426073 - Flags: review?(gaye) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/1194951ca3ce7c254a5f246f8e92ad5025795e4b
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: