1008134 - darkwindowframe attribute should be set before the first paint

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

It's currently being set in _delayedStartup, which is after the first paint.

Comment 1

[:Gijs (he/him)]

Comment on attachment 8420042 [details] [diff] [review]
patch

Review of attachment 8420042 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming you're just moving things (it looks like that, but splinter is... nonoptimal... for checking it), rs=me

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8420042 [details] [diff] [review]
patch

(In reply to :Gijs Kruitbosch from comment #1)
> Assuming you're just moving things (it looks like that, but splinter is...
> nonoptimal... for checking it), rs=me

I did some minor cleanup:

>-      let windows8WindowFrameColor = Cu.import("resource:///modules/Windows8WindowFrameColor.jsm", {}).Windows8WindowFrameColor;
>-      let windowFrameColor = windows8WindowFrameColor.get();

>+      let windowFrameColor = Cu.import("resource:///modules/Windows8WindowFrameColor.jsm", {})
>+                               .Windows8WindowFrameColor.get();

Comment 3

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 8420042 [details] [diff] [review]
> patch
> 
> (In reply to :Gijs Kruitbosch from comment #1)
> > Assuming you're just moving things (it looks like that, but splinter is...
> > nonoptimal... for checking it), rs=me
> 
> I did some minor cleanup:
> 
> >-      let windows8WindowFrameColor = Cu.import("resource:///modules/Windows8WindowFrameColor.jsm", {}).Windows8WindowFrameColor;
> >-      let windowFrameColor = windows8WindowFrameColor.get();
> 
> >+      let windowFrameColor = Cu.import("resource:///modules/Windows8WindowFrameColor.jsm", {})
> >+                               .Windows8WindowFrameColor.get();

Ship it! :-)

Comment 4

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/d78df4c9cded

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d78df4c9cded

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8420042 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 940393
User impact if declined: this is needed in order to uplift the patch in bug 1012629
Testing completed (on m-c, etc.): landed almost 2 weeks ago on m-c
Risk to taking this patch (and alternatives if risky): low; just moving code around, no new code
String or IDL/UUID changes made by this patch: none

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47fc3c9a5830