Closed Bug 1008195 Opened 10 years ago Closed 10 years ago

Clicking on the notification icon should toggle the translation infobar

Categories

(Firefox :: Translations, defect)

Product:
Firefox
Component:
Translations
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 32

People

(Reporter: jaws, Assigned: florian)

Details

(Whiteboard: p=2 s=it-32c-31a-30b.2 [qa!])

Attachments

(1 file)

Patch
4.11 KB, patch
Felipe
: review+
Details | Diff | Splinter Review 
      No description provided.
The icon currently only works to display the infobar if it's been hidden. But if the infobar is visible, it doesn't do anything when clicked.
Flags: firefox-backlog+
I would likely have implemented this in bug 974461 if I had understood at the time that this is the desired behavior.

Sevaan clarified the expected behavior on IRC this week:
18:03:29 - flo-retina: sevaan: when the translation infobar is visible and the user clicks the icon near the URL bar, should we hide the infobar? Currently we do nothing.
[...]
18:07:12 - sevaan: flo-retina: Clicking on the icon should always toggle the infobar on/off.
Whiteboard: p=0
Whiteboard: p=0 → p=2
Assignee: nobody → florian
Status: NEW → ASSIGNED
Whiteboard: p=2 → p=2 s=it-32c-31a-30b.2 [qa?]
Whiteboard: p=2 s=it-32c-31a-30b.2 [qa?] → p=2 s=it-32c-31a-30b.2 [qa+]
Attached patch Patch — — Splinter Review 

    
  

        Attachment #8423904 -
        Flags: review?(felipc)

        Attachment #8423904 -
        Flags: review?(felipc) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9f5506422e9e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
QA Contact: bogdan.maris

    
    

    
  
Verified that the toggle works as expected on a try-build in Ubuntu 14.04 32bit, Mac OS X 10.9.2 and Windows 8.1 64bit.
Status: RESOLVED → VERIFIED
Whiteboard: p=2 s=it-32c-31a-30b.2 [qa+] → p=2 s=it-32c-31a-30b.2 [qa!]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: