Closed Bug 1008201 Opened 10 years ago Closed 10 years ago

Need to have (new?) Loop toolbar icon styled & correctly displayed in all places

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
2

Tracking

(firefox34 verified)

Status:
VERIFIED FIXED
Milestone:
34 Sprint 1- 8/4
Iteration:
34.1
Tracking Flags:
Tracking Status
firefox34 --- verified

People

(Reporter: standard8, Assigned: mikedeboer)

References

Details

User Story

The toolbar icon is currently just 16x16. It needs to be displayed properly for:

- Toolbar
- Retina displays
- In the customise toolbar dialog
- In the app menu
- On all 3 platforms (if the image is different)

Most of this is probably finding an existing button (e.g. home button) and copying the appropriate CSS. We might need some image maps generating to load the images from.

Attachments

(4 files)

Customize_Nightly.png
778.13 KB, image/png
Details
Loop_icon_071014.zip
73.56 KB, application/zip
Details
Patch v1: update Loop toolbar icon to a speech bubble
81.88 KB, patch
jaws
: review+
Details | Diff | Splinter Review
screenshot
143.14 KB, image/png
Details 
The temporary phone icon will probably want replacing for MVP. In any case, we should make sure that it is correctly displayed in all cases.

See the user story for more info.
User Story: (updated)
Summary: Need to have (new?) Loop logo styled & correctly displayed in all places → Need to have (new?) Loop toolbar icon styled & correctly displayed in all places
Priority: -- → P1
Whiteboard: [s=ui32]
Target Milestone: --- → mozilla32
Whiteboard: [s=ui32] → p=?
Target Milestone: mozilla32 → mozilla33
Blocks: 1014571
No longer blocks: 972014
This should be done after bug 1011392, as that will get it working everywhere.
Depends on: 1011392
need a new icon from Darrin and then in all the various scales and some CSS work to replace the tool bar icons and copy/paste new icon.  we could do or someone like Mark.
Flags: needinfo?(dhenein)
Whiteboard: p=? → p=1
Attached image Customize_Nightly.png — 
Added screenshot in latest Nightly. Note that it is very blocky (16x16?) and is missing a label.
(In reply to Peter deHaan [:pdehaan] from comment #4)
> Added screenshot in latest Nightly. Note that it is very blocky (16x16?) and
> is missing a label.

Missing label is bug 1013989.
Whiteboard: p=1 → [p=1][browser][need icon]
Blocks: 1028894
I believe Darrin has the new icon and that it should work almost regardless of how the naming discussions end up.  This should allow us to make this bug about the eng work associated with the new icon.  Darrin--can you confirm that the "speech bubble" concept is final?
Flags: needinfo?(dhenein)
now with a flag for darrin
Flags: needinfo?(dhenein)
All of the assets and details are over in https://bugzilla.mozilla.org/show_bug.cgi?id=1028894.
Flags: needinfo?(dhenein)
Assignee: nobody → mmaslaney
Status: NEW → ASSIGNED
Whiteboard: [p=1][browser][need icon] → [browser][need icon] p=5 s=33.3 [qa-]
Attached file Loop_icon_071014.zip — 
Attached, the Toolbar and Menu Panel Loop glyph for Windows, OS X and Linux.
Target Milestone: mozilla33 → 33 Sprint 3- 7/21
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reopening as this isn't fully fixed - although we now have image strips, the browser hasn't been updated as described in the user story.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
UX component complete.  Removing tags to restore this to an ENG bug.

(In reply to Mark Banner (:standard8) from comment #10)
> Reopening as this isn't fully fixed - although we now have image strips, the
> browser hasn't been updated as described in the user story.
Assignee: mmaslaney → nobody
Status: REOPENED → NEW
Whiteboard: [browser][need icon] p=5 s=33.3 [qa-] → [browser][need icon]
Target Milestone: 33 Sprint 3- 7/21 → mozilla34
Whiteboard: [browser][need icon] → [p=?]
Points: --- → 2
Whiteboard: [p=?] → [first release needed][qa+]
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Hi Mike, are you picking this bug up for Iteration 34.1?
Flags: needinfo?(mdeboer)
(In reply to Marco Mucci [:MarcoM] from comment #12)
> Hi Mike, are you picking this bug up for Iteration 34.1?

Yes.
Flags: needinfo?(mdeboer)
Iteration: --- → 34.1
Whiteboard: [first release needed][qa+] → [first release needed] [qa+]
Hi Michael, I'm missing the loop-toolbar-inverted.png for Linux. Should I (re-)use the Window one?
Flags: needinfo?(mmaslaney)
Can you confirm this is tracking the implementation of the speech bubble icon in the toolbar as a replacement of the phone icon?
https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#toolbar
(In reply to Romain Testard [:RT] from comment #15)
> Can you confirm this is tracking the implementation of the speech bubble
> icon in the toolbar as a replacement of the phone icon?
> https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#toolbar

Confirmed.
I'm removing "first release needed" because we want this independent of the direct calling and contacts work.
Whiteboard: [first release needed] [qa+] → [qa+]
Target Milestone: mozilla34 → 34 Sprint 1- 8/4
(In reply to Mike de Boer [:mikedeboer] from comment #14)
> Hi Michael, I'm missing the loop-toolbar-inverted.png for Linux. Should I
> (re-)use the Window one?

Mike, I'm not seeing a source file in our assets library. I'm thinking we're either using the Windows or OSX glyph set for linux.
Flags: needinfo?(mmaslaney)
Jared, are you ok with reviewing this?

I'm using the Windows-style inverted icons on Linux, just like we do everywhere else.
Attachment #8465503 - Flags: review?(jaws)
QA Contact: cornel.ionce
Attachment #8465503 - Flags: review?(jaws) → review+
Blocks: 1047284
Flags: firefox-backlog+
(Commenting on User Story)
> The toolbar icon is currently just 16x16. It needs to be displayed properly
> for:
> 
> - Retina displays

The new icon is not retina friendly, at least in the hamburger menu.
Attached image screenshot — 
I forgot to attach a screenshot.
The icon is not correctly size in the customization palette on Windows and doesn't have any animation when grabbed.
https://hg.mozilla.org/mozilla-central/rev/2fbc796ca3e2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Depends on: 1048144
(In reply to Sören Hentzschel from comment #21)
> The new icon is not retina friendly, at least in the hamburger menu.

Filed bug 1048144 to track menu-panel and palette issue(s).
So now, we have the new Loop icon in the toolbar, menu panel and the palette.
Tested on 34.0a1 (2014-08-04), Win 7, OS X 10.9.4, Ubuntu 12.10.
Remaining work will be done in bug 1048103, bug 1048144.
Status: RESOLVED → VERIFIED
status-firefox34: --- → verified
QA Contact: cornel.ionce → paul.silaghi
Whiteboard: [qa+] → [qa!]
Flags: qe-verify+
Whiteboard: [qa!]
Depends on: 1088568
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: