1008316 - enable test_ev_certs.js on B2G when libpkix isn't being used and (if) EV is re-enabled on B2G

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

libpkix is disabled on B2G. Part of test_ev_certs.js depends on it (the classic-mode verification). Probably the easiest thing to do is to not test classic mode for that test on B2G.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: patch

Comment 2

[Camilo Viecco (:cviecco)]

Comment on attachment 8432789 [details] [diff] [review]
patch

Review of attachment 8432789 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/tests/unit/test_ev_certs.js
@@ +67,5 @@
>      do_check_eq(hasEVPolicy.value, expected_ev);
>      do_check_eq(0, error);
>  }
>  
> +const gIsB2G = ("@mozilla.org/b2g-process-global;1" in Cc);

should this live on head.psm instead?

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I was thinking we could move it if/when more than one test needs it.

Comment 4

[Camilo Viecco (:cviecco)]

Agreed.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks for the review.
https://tbpl.mozilla.org/?tree=Try&rev=2d25b1eea81a

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Actually, I'm not even sure what I was thinking with this bug. We have a build flag (MOZ_NO_EV_CERTS) that essentially disables EV checking on B2G. So it doesn't make sense at all to run this test on that platform. I think I'll morph this bug to enable this test on B2G when libpkix is not being used at all and (if) we enable EV on B2G.

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I don't think we should put effort into this without a clear signal that folks working on B2G want this.