1008338 - Add WorkerScriptExecutedSuccessfully()

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This is required for ServiceWorkers Update() algorithm, where on "parse errors or uncaught errors" we need to reject Promises instead of bubbling the error up the tree.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Add WorkerScriptExecutedSuccessfully().

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8420265 [details] [diff] [review]
Add WorkerScriptExecutedSuccessfully().

Bad MQ

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Add WorkerScriptExecutedSuccessfully().

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8420302 [details] [diff] [review]
Add WorkerScriptExecutedSuccessfully().

Review of attachment 8420302 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with these fixed:

::: dom/workers/WorkerPrivate.h
@@ +1069,5 @@
>    { }
>  #endif
>  
> +  void
> +  SetWorkerScriptExecutedSuccessfully(bool aValue)

I don't think that this should take a value since you should never need to call it more than once, it starts off as false, and you only need to set it to true.

Also, this needs a AssertIsOnWorkerThread and an assertion to never let it be called more than once.

@@ +1075,5 @@
> +    mWorkerScriptExecutedSuccessfully = aValue;
> +  }
> +
> +  bool
> +  WorkerScriptExecutedSuccessfully()

Nit: make this a const method.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8420302 [details] [diff] [review]
Add WorkerScriptExecutedSuccessfully().

Review of attachment 8420302 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.h
@@ +1075,5 @@
> +    mWorkerScriptExecutedSuccessfully = aValue;
> +  }
> +
> +  bool
> +  WorkerScriptExecutedSuccessfully()

This needs the AssertIsOnWorkerThread call too.

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/388f59954ef6

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/388f59954ef6