1008371 - [B2G][Camera][1.4] Camera remains in a faux recording state when pressing record followed by sleep

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Eric Kramer [:Kramer]]

Attachment: This logcat ends when the phone was put to sleep.

Description:
The camera can remain in a recording state when the phone is not actually recording. The timed counts up and the action button is "Stop Recording" icon. However, no video is recorded / saved when stop is pressed. This is done by pressing the power button immediately after hearing the recording started bloop. When the user unlocks thier phone it will look like the phone is still recording. 


Repro Steps:
1) Update a Open_C to BuildID: 20140509000203
2) Launch the camera app and switch it to Video Record
3) Press record
4) As soon as the bloop sound is heard, press the power button to put the phone to sleep
5) Press the power button again to wake the phone up
6) Slide unlock either direction (both repro issue)


Actual:
The Camera will appear to still be in a "recording" state. For example, the timer will be counting up and the icon will be "Stop Recording" and not "Start Recording." Pressing stop will not result in a video being saved, even though it looks like it has been recording.

Expected:
The camera is placed into a clear "ready to record" state. All traces of the previous record attempt are removed. 

1.4 Environmental Variables:
Device: Open_C 1.4
BuildID: 20140509000203
Gaia: f19735d288d9bf1c6ee0c0ecc7941421365037c7
Gecko: 33aff135dc42
Version: 30.0
Firmware Version: FFOS_US_EBAY_P821A10V1.0.0B06_LOG_DL


Repro frequency: (4/5)
See attached: (Video clip, logcat)

Notes:
This issue reproduces on Buri 1.4
1.4 Environmental Variables:
Device: Buri 1.4
BuildID: 20140508000201
Gaia: 4ce973ef0732b0d52cb043210db598aa176b2ce9
Gecko: 16ab7f6b18f8
Version: 30.0
Firmware Version: v1.2-device.cfg

Comment 1

[Eric Kramer [:Kramer]]

Added Video URL and Whiteboard tag: [openc-1.4-exploratory]

QAWanted: Can we check this on Open_C base?

Comment 2

[Eric Kramer [:Kramer]]

Qawanted: Human error, not Open_C Base. Can we check this on Buri 1.3?

Comment 3

[Joshua Mitchell (Inactive)]

This does NOT reproduce on Buri 1.3

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140508024005
Gaia: 0d02564946814acfdab13f0b9867d140d318b8ac
Gecko: a7252ab569c4
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 4

[Jason Smith [:jsmith]]

If you put the phone to sleep after recording for a few seconds, then does this bug reproduce?

Comment 5

[Eric Kramer [:Kramer]]

This issue does NOT reproduce if the phone is put sleep after recording for a few seconds. The recording properly turns off when the phone is put to sleep after a few seconds of recording.

Comment 6

[Jason Smith [:jsmith]]

The STR is quite hard to hit & recoverable, so I don't think I'd hold a release on this.

Comment 7

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 8

[Wilson Page [:wilsonpage]]

SUMMARY

Addressed problem with recording videos too short in a more robust way. Now we don't interrupt the stopRecording flow completely, instead we let it complete and erase the invalid video file at the end of the process. This means the camera is never left appearing to still be recording even though the recording has ended.

This was logic previously used `window` globals, I used this opportunity to remove that dependency and to move default configuration into camera.js. This makes the Camera hardware layer a little more self contained. Camera defaults can still be overridden by defining values in the new `camera` object inside config.js.

The `Camera#stopRecording()` logic previously had no unit-test coverage. This patch adds complete coverage to all code paths.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8421813 [details] [review]
pull-request (master)

Looks good!

Comment 10

[Wilson Page [:wilsonpage]]

Landed on 'master' https://github.com/mozilla-b2g/gaia/commit/7a906f695777c7a12b020d7766c59f2307816658