1008402 - Downloads toolbar icon changes color on click (white > dark grey) when using a light-text (dark background) light-weight theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Nathan V]

Attachment: dark downloads white menu.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140509030227

Steps to reproduce:

- Install dark colored persona/theme (e.g. https://addons.mozilla.org/en-US/firefox/addon/bamboo-dark-blue/ )
- [optional] restart your browser
- click the downloads toolbar icon (to bring up the popup).


Actual results:

The icon will change color schemes from white (for dark themes) to dark grey (for light themes) and will stay that way until a browser restart.


Expected results:

The icon should not change color on click.

Comment 1

[:Gijs (he/him)]

Thanks for the report! You reported this against 32 - do you know if this broke recently, or when?

Comment 2

[Nathan V]

(In reply to :Gijs Kruitbosch from comment #1)
> Thanks for the report! You reported this against 32 - do you know if this
> broke recently, or when?

This has been happening for a few releases, but since I used a light GTK theme + default skin, it didn't bother me (I figured somebody would work it out). Since I've finally settled on a nice dark theme, it's started becoming annoying so I filed the bug.

It happens for any dark theme I've tried. My current install of Nightly is fresh from a month or two ago, so I don't think it's a me-specific thing.

Comment 3

[moses]

Gijs,

I can confirm this running Beta(30) and Nightly(32) using Ubuntu 12.04.4 LTS

Comment 4

[:Gijs (he/him)]

Looks like we forgot to update this when we organized linux icons, because bug 890039 fixed this on Windows and OS X. Sigh.

Comment 5

[:Gijs (he/him)]

Attachment: linux downloads button icon loses lwtheme color if using dark lwtheme (bright text),

Totally cargo-culting the windows styles here, but the back of my mind is wondering what the 12px case is all about. If I start downloading something, I no longer see a download icon at all... just the number of seconds/minutes, and a progress bar. Mike, can you elucidate?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8421348 [details] [diff] [review]
linux downloads button icon loses lwtheme color if using dark lwtheme (bright text),

Review of attachment 8421348 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Thanks Gijs!

Comment 7

[:Gijs (he/him)]

Comment on attachment 8421348 [details] [diff] [review]
linux downloads button icon loses lwtheme color if using dark lwtheme (bright text),

https://hg.mozilla.org/integration/fx-team/rev/94e13ebd9cbc

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: download icon switches back to dark (becoming hard to see) on black LWTs on Linux
Testing completed (on m-c, etc.): local, soon on m-c
Risk to taking this patch (and alternatives if risky): very low / none - CSS only patch
String or IDL/UUID changes made by this patch: none

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/94e13ebd9cbc

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/326458a1a95b
https://hg.mozilla.org/releases/mozilla-beta/rev/792de35e26c0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/792de35e26c0

Comment 11

[moses]

Just tested this in the latest beta and Aurora with the theme provided by Nathan in comment #1. Works great!