Closed
Bug 1008402
Opened 10 years ago
Closed 10 years ago
Downloads toolbar icon changes color on click (white > dark grey) when using a light-text (dark background) light-weight theme
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 32
People
(Reporter: catlover109, Assigned: Gijs)
References
Details
Attachments
(2 files)
5.34 KB,
image/png
|
Details | |
2.92 KB,
patch
|
mconley
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
Gijs
:
checkin+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release) Build ID: 20140509030227 Steps to reproduce: - Install dark colored persona/theme (e.g. https://addons.mozilla.org/en-US/firefox/addon/bamboo-dark-blue/ ) - [optional] restart your browser - click the downloads toolbar icon (to bring up the popup). Actual results: The icon will change color schemes from white (for dark themes) to dark grey (for light themes) and will stay that way until a browser restart. Expected results: The icon should not change color on click.
Severity: normal → trivial
Component: Untriaged → Toolbars and Customization
Assignee | ||
Comment 1•10 years ago
|
||
Thanks for the report! You reported this against 32 - do you know if this broke recently, or when?
Component: Toolbars and Customization → Theme
Flags: needinfo?(catlover109)
Flags: firefox-backlog+
Summary: Downloads toolbar icon changes color on click (white > dark grey) → Downloads toolbar icon changes color on click (white > dark grey) when using a light-text (dark background) light-weight theme
(In reply to :Gijs Kruitbosch from comment #1) > Thanks for the report! You reported this against 32 - do you know if this > broke recently, or when? This has been happening for a few releases, but since I used a light GTK theme + default skin, it didn't bother me (I figured somebody would work it out). Since I've finally settled on a nice dark theme, it's started becoming annoying so I filed the bug. It happens for any dark theme I've tried. My current install of Nightly is fresh from a month or two ago, so I don't think it's a me-specific thing.
Flags: needinfo?(catlover109)
Gijs, I can confirm this running Beta(30) and Nightly(32) using Ubuntu 12.04.4 LTS
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [testday-20140509]
Assignee | ||
Comment 4•10 years ago
|
||
Looks like we forgot to update this when we organized linux icons, because bug 890039 fixed this on Windows and OS X. Sigh.
Assignee | ||
Comment 5•10 years ago
|
||
Totally cargo-culting the windows styles here, but the back of my mind is wondering what the 12px case is all about. If I start downloading something, I no longer see a download icon at all... just the number of seconds/minutes, and a progress bar. Mike, can you elucidate?
Attachment #8421348 -
Flags: review?(mconley)
Comment 6•10 years ago
|
||
Comment on attachment 8421348 [details] [diff] [review] linux downloads button icon loses lwtheme color if using dark lwtheme (bright text), Review of attachment 8421348 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! Thanks Gijs!
Attachment #8421348 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8421348 [details] [diff] [review] linux downloads button icon loses lwtheme color if using dark lwtheme (bright text), https://hg.mozilla.org/integration/fx-team/rev/94e13ebd9cbc [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A User impact if declined: download icon switches back to dark (becoming hard to see) on black LWTs on Linux Testing completed (on m-c, etc.): local, soon on m-c Risk to taking this patch (and alternatives if risky): very low / none - CSS only patch String or IDL/UUID changes made by this patch: none
Attachment #8421348 -
Flags: checkin+
Attachment #8421348 -
Flags: approval-mozilla-beta?
Attachment #8421348 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/94e13ebd9cbc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8421348 -
Flags: approval-mozilla-beta?
Attachment #8421348 -
Flags: approval-mozilla-beta+
Attachment #8421348 -
Flags: approval-mozilla-aurora?
Attachment #8421348 -
Flags: approval-mozilla-aurora+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/326458a1a95b https://hg.mozilla.org/releases/mozilla-beta/rev/792de35e26c0
Comment 11•10 years ago
|
||
Just tested this in the latest beta and Aurora with the theme provided by Nathan in comment #1. Works great!
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•